Title: [205605] releases/WebKitGTK/webkit-2.14/Source/_javascript_Core
Revision
205605
Author
[email protected]
Date
2016-09-08 01:23:35 -0700 (Thu, 08 Sep 2016)

Log Message

Revert "Unreviewed. Remove incorrect assert causing crashes in debug builds."

This reverts commit 6e6102ed50f641baac41e5f953a1b9118e030ebe.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog (205604 => 205605)


--- releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog	2016-09-08 08:19:12 UTC (rev 205604)
+++ releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog	2016-09-08 08:23:35 UTC (rev 205605)
@@ -602,13 +602,6 @@
         (JSC::getWeakMapData):
         (JSC::protoFuncWeakSetAdd):
 
-2016-08-30  Carlos Garcia Campos  <[email protected]>
-
-        Unreviewed. Remove incorrect assert causing crashes in debug builds.
-
-        * dfg/DFGAbstractValue.h:
-        (JSC::DFG::AbstractValue::AbstractValue):
-
 2016-08-29  Joseph Pecoraro  <[email protected]>
 
         REGRESSION(r202568): Web Inspector: Expanding Array Prototype in Console shows no properties

Modified: releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/dfg/DFGAbstractValue.h (205604 => 205605)


--- releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/dfg/DFGAbstractValue.h	2016-09-08 08:19:12 UTC (rev 205604)
+++ releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/dfg/DFGAbstractValue.h	2016-09-08 08:23:35 UTC (rev 205605)
@@ -55,6 +55,17 @@
         : m_type(SpecNone)
         , m_arrayModes(0)
     {
+#if USE(JSVALUE64) && !defined(NDEBUG)
+        // The WTF Traits for AbstractValue allow the initialization of values with bzero().
+        // We verify the correctness of this assumption here.
+        static bool needsDefaultConstructorCheck = true;
+        if (needsDefaultConstructorCheck) {
+            needsDefaultConstructorCheck = false;
+
+            for (unsigned i = 0; i < sizeof(AbstractValue); ++i)
+                ASSERT(!(reinterpret_cast<char*>(this)[i]));
+        }
+#endif
     }
     
     void clear()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to