Title: [205631] releases/WebKitGTK/webkit-2.14/Tools
Revision
205631
Author
[email protected]
Date
2016-09-08 05:20:57 -0700 (Thu, 08 Sep 2016)

Log Message

Merge r205343 - [GTK] Fix compiler warning in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=161529

We were missing a return statement in decidePermissionRequest() and
also there was unused variable in browserWindowConstructed().

Patch by Tomas Popela <[email protected]> on 2016-09-02
Reviewed by Carlos Garcia Campos.

* MiniBrowser/gtk/BrowserTab.c:
(decidePermissionRequest):
* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowConstructed):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Tools/ChangeLog (205630 => 205631)


--- releases/WebKitGTK/webkit-2.14/Tools/ChangeLog	2016-09-08 12:20:05 UTC (rev 205630)
+++ releases/WebKitGTK/webkit-2.14/Tools/ChangeLog	2016-09-08 12:20:57 UTC (rev 205631)
@@ -1,3 +1,18 @@
+2016-09-02  Tomas Popela  <[email protected]>
+
+        [GTK] Fix compiler warning in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=161529
+
+        We were missing a return statement in decidePermissionRequest() and
+        also there was unused variable in browserWindowConstructed().
+
+        Reviewed by Carlos Garcia Campos.
+
+        * MiniBrowser/gtk/BrowserTab.c:
+        (decidePermissionRequest):
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowConstructed):
+
 2016-08-30  Brent Fulgham  <[email protected]>
 
         Use of uninitialised memory in TransformationMatrx::blend4()

Modified: releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserTab.c (205630 => 205631)


--- releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserTab.c	2016-09-08 12:20:05 UTC (rev 205630)
+++ releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserTab.c	2016-09-08 12:20:57 UTC (rev 205631)
@@ -225,6 +225,8 @@
     gtk_box_pack_start(GTK_BOX(tab), dialog, FALSE, FALSE, 0);
     gtk_box_reorder_child(GTK_BOX(tab), dialog, 0);
     gtk_widget_show(dialog);
+
+    return TRUE;
 }
 
 #if GTK_CHECK_VERSION(3, 12, 0)

Modified: releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserWindow.c (205630 => 205631)


--- releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserWindow.c	2016-09-08 12:20:05 UTC (rev 205630)
+++ releases/WebKitGTK/webkit-2.14/Tools/MiniBrowser/gtk/BrowserWindow.c	2016-09-08 12:20:57 UTC (rev 205631)
@@ -952,8 +952,6 @@
 
 static void browserWindowConstructed(GObject *gObject)
 {
-    BrowserWindow *window = BROWSER_WINDOW(gObject);
-
     G_OBJECT_CLASS(browser_window_parent_class)->constructed(gObject);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to