Title: [205665] trunk
- Revision
- 205665
- Author
- [email protected]
- Date
- 2016-09-08 15:02:39 -0700 (Thu, 08 Sep 2016)
Log Message
HTMLImageElement.hspace / vspace attributes should be unsigned
https://bugs.webkit.org/show_bug.cgi?id=161754
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
* web-platform-tests/html/dom/reflection-embedded-expected.txt:
Source/WebCore:
HTMLImageElement.hspace / vspace attributes should be unsigned:
- https://html.spec.whatwg.org/#HTMLImageElement-partial
Firefox agrees with the specification, however, those were signed in
webKit.
No new tests, rebaselined existing test.
* html/HTMLImageElement.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (205664 => 205665)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-08 22:00:52 UTC (rev 205664)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-08 22:02:39 UTC (rev 205665)
@@ -1,5 +1,16 @@
2016-09-08 Chris Dumez <[email protected]>
+ HTMLImageElement.hspace / vspace attributes should be unsigned
+ https://bugs.webkit.org/show_bug.cgi?id=161754
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline W3C test now that more checks are passing.
+
+ * web-platform-tests/html/dom/reflection-embedded-expected.txt:
+
+2016-09-08 Chris Dumez <[email protected]>
+
HTMLImageElement.width / height attributes should be unsigned
https://bugs.webkit.org/show_bug.cgi?id=161730
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205664 => 205665)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-08 22:00:52 UTC (rev 205664)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-08 22:02:39 UTC (rev 205665)
@@ -1426,11 +1426,11 @@
PASS img.hspace: setAttribute() to -2147483649 followed by getAttribute()
PASS img.hspace: setAttribute() to -2147483649 followed by IDL get
PASS img.hspace: setAttribute() to -2147483648 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.hspace: setAttribute() to -2147483648 followed by IDL get
PASS img.hspace: setAttribute() to -36 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS img.hspace: setAttribute() to -36 followed by IDL get
PASS img.hspace: setAttribute() to -1 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: setAttribute() to -1 followed by IDL get
PASS img.hspace: setAttribute() to 0 followed by getAttribute()
PASS img.hspace: setAttribute() to 0 followed by IDL get
PASS img.hspace: setAttribute() to 1 followed by getAttribute()
@@ -1448,7 +1448,7 @@
PASS img.hspace: setAttribute() to "" followed by getAttribute()
PASS img.hspace: setAttribute() to "" followed by IDL get
PASS img.hspace: setAttribute() to "-1" followed by getAttribute()
-FAIL img.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: setAttribute() to "-1" followed by IDL get
PASS img.hspace: setAttribute() to "-0" followed by getAttribute()
PASS img.hspace: setAttribute() to "-0" followed by IDL get
PASS img.hspace: setAttribute() to "0" followed by getAttribute()
@@ -1545,21 +1545,21 @@
PASS img.hspace: IDL set to "-0" followed by getAttribute()
PASS img.hspace: IDL set to "-0" followed by IDL get
PASS img.hspace: IDL set to 2147483648 should not throw
-FAIL img.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL img.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.hspace: IDL set to 2147483648 followed by getAttribute()
+PASS img.hspace: IDL set to 2147483648 followed by IDL get
PASS img.hspace: IDL set to 4294967295 should not throw
-FAIL img.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL img.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: IDL set to 4294967295 followed by getAttribute()
+PASS img.hspace: IDL set to 4294967295 followed by IDL get
PASS img.vspace: typeof IDL attribute
PASS img.vspace: IDL get with DOM attribute unset
PASS img.vspace: setAttribute() to -2147483649 followed by getAttribute()
PASS img.vspace: setAttribute() to -2147483649 followed by IDL get
PASS img.vspace: setAttribute() to -2147483648 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.vspace: setAttribute() to -2147483648 followed by IDL get
PASS img.vspace: setAttribute() to -36 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS img.vspace: setAttribute() to -36 followed by IDL get
PASS img.vspace: setAttribute() to -1 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: setAttribute() to -1 followed by IDL get
PASS img.vspace: setAttribute() to 0 followed by getAttribute()
PASS img.vspace: setAttribute() to 0 followed by IDL get
PASS img.vspace: setAttribute() to 1 followed by getAttribute()
@@ -1577,7 +1577,7 @@
PASS img.vspace: setAttribute() to "" followed by getAttribute()
PASS img.vspace: setAttribute() to "" followed by IDL get
PASS img.vspace: setAttribute() to "-1" followed by getAttribute()
-FAIL img.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: setAttribute() to "-1" followed by IDL get
PASS img.vspace: setAttribute() to "-0" followed by getAttribute()
PASS img.vspace: setAttribute() to "-0" followed by IDL get
PASS img.vspace: setAttribute() to "0" followed by getAttribute()
@@ -1674,11 +1674,11 @@
PASS img.vspace: IDL set to "-0" followed by getAttribute()
PASS img.vspace: IDL set to "-0" followed by IDL get
PASS img.vspace: IDL set to 2147483648 should not throw
-FAIL img.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL img.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.vspace: IDL set to 2147483648 followed by getAttribute()
+PASS img.vspace: IDL set to 2147483648 followed by IDL get
PASS img.vspace: IDL set to 4294967295 should not throw
-FAIL img.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL img.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: IDL set to 4294967295 followed by getAttribute()
+PASS img.vspace: IDL set to 4294967295 followed by IDL get
PASS img.longDesc: typeof IDL attribute
PASS img.longDesc: IDL get with DOM attribute unset
PASS img.longDesc: setAttribute() to "" followed by getAttribute()
Modified: trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt (205664 => 205665)
--- trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-08 22:00:52 UTC (rev 205664)
+++ trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt 2016-09-08 22:02:39 UTC (rev 205665)
@@ -1426,11 +1426,11 @@
PASS img.hspace: setAttribute() to -2147483649 followed by getAttribute()
PASS img.hspace: setAttribute() to -2147483649 followed by IDL get
PASS img.hspace: setAttribute() to -2147483648 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.hspace: setAttribute() to -2147483648 followed by IDL get
PASS img.hspace: setAttribute() to -36 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS img.hspace: setAttribute() to -36 followed by IDL get
PASS img.hspace: setAttribute() to -1 followed by getAttribute()
-FAIL img.hspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: setAttribute() to -1 followed by IDL get
PASS img.hspace: setAttribute() to 0 followed by getAttribute()
PASS img.hspace: setAttribute() to 0 followed by IDL get
PASS img.hspace: setAttribute() to 1 followed by getAttribute()
@@ -1448,7 +1448,7 @@
PASS img.hspace: setAttribute() to "" followed by getAttribute()
PASS img.hspace: setAttribute() to "" followed by IDL get
PASS img.hspace: setAttribute() to "-1" followed by getAttribute()
-FAIL img.hspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: setAttribute() to "-1" followed by IDL get
PASS img.hspace: setAttribute() to "-0" followed by getAttribute()
PASS img.hspace: setAttribute() to "-0" followed by IDL get
PASS img.hspace: setAttribute() to "0" followed by getAttribute()
@@ -1545,21 +1545,21 @@
PASS img.hspace: IDL set to "-0" followed by getAttribute()
PASS img.hspace: IDL set to "-0" followed by IDL get
PASS img.hspace: IDL set to 2147483648 should not throw
-FAIL img.hspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL img.hspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.hspace: IDL set to 2147483648 followed by getAttribute()
+PASS img.hspace: IDL set to 2147483648 followed by IDL get
PASS img.hspace: IDL set to 4294967295 should not throw
-FAIL img.hspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL img.hspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.hspace: IDL set to 4294967295 followed by getAttribute()
+PASS img.hspace: IDL set to 4294967295 followed by IDL get
PASS img.vspace: typeof IDL attribute
PASS img.vspace: IDL get with DOM attribute unset
PASS img.vspace: setAttribute() to -2147483649 followed by getAttribute()
PASS img.vspace: setAttribute() to -2147483649 followed by IDL get
PASS img.vspace: setAttribute() to -2147483648 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.vspace: setAttribute() to -2147483648 followed by IDL get
PASS img.vspace: setAttribute() to -36 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -36 followed by IDL get assert_equals: expected 0 but got -36
+PASS img.vspace: setAttribute() to -36 followed by IDL get
PASS img.vspace: setAttribute() to -1 followed by getAttribute()
-FAIL img.vspace: setAttribute() to -1 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: setAttribute() to -1 followed by IDL get
PASS img.vspace: setAttribute() to 0 followed by getAttribute()
PASS img.vspace: setAttribute() to 0 followed by IDL get
PASS img.vspace: setAttribute() to 1 followed by getAttribute()
@@ -1577,7 +1577,7 @@
PASS img.vspace: setAttribute() to "" followed by getAttribute()
PASS img.vspace: setAttribute() to "" followed by IDL get
PASS img.vspace: setAttribute() to "-1" followed by getAttribute()
-FAIL img.vspace: setAttribute() to "-1" followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: setAttribute() to "-1" followed by IDL get
PASS img.vspace: setAttribute() to "-0" followed by getAttribute()
PASS img.vspace: setAttribute() to "-0" followed by IDL get
PASS img.vspace: setAttribute() to "0" followed by getAttribute()
@@ -1674,11 +1674,11 @@
PASS img.vspace: IDL set to "-0" followed by getAttribute()
PASS img.vspace: IDL set to "-0" followed by IDL get
PASS img.vspace: IDL set to 2147483648 should not throw
-FAIL img.vspace: IDL set to 2147483648 followed by getAttribute() assert_equals: expected "0" but got "-2147483648"
-FAIL img.vspace: IDL set to 2147483648 followed by IDL get assert_equals: expected 0 but got -2147483648
+PASS img.vspace: IDL set to 2147483648 followed by getAttribute()
+PASS img.vspace: IDL set to 2147483648 followed by IDL get
PASS img.vspace: IDL set to 4294967295 should not throw
-FAIL img.vspace: IDL set to 4294967295 followed by getAttribute() assert_equals: expected "0" but got "-1"
-FAIL img.vspace: IDL set to 4294967295 followed by IDL get assert_equals: expected 0 but got -1
+PASS img.vspace: IDL set to 4294967295 followed by getAttribute()
+PASS img.vspace: IDL set to 4294967295 followed by IDL get
PASS img.longDesc: typeof IDL attribute
PASS img.longDesc: IDL get with DOM attribute unset
PASS img.longDesc: setAttribute() to "" followed by getAttribute()
Modified: trunk/Source/WebCore/ChangeLog (205664 => 205665)
--- trunk/Source/WebCore/ChangeLog 2016-09-08 22:00:52 UTC (rev 205664)
+++ trunk/Source/WebCore/ChangeLog 2016-09-08 22:02:39 UTC (rev 205665)
@@ -1,5 +1,22 @@
2016-09-08 Chris Dumez <[email protected]>
+ HTMLImageElement.hspace / vspace attributes should be unsigned
+ https://bugs.webkit.org/show_bug.cgi?id=161754
+
+ Reviewed by Alex Christensen.
+
+ HTMLImageElement.hspace / vspace attributes should be unsigned:
+ - https://html.spec.whatwg.org/#HTMLImageElement-partial
+
+ Firefox agrees with the specification, however, those were signed in
+ webKit.
+
+ No new tests, rebaselined existing test.
+
+ * html/HTMLImageElement.idl:
+
+2016-09-08 Chris Dumez <[email protected]>
+
Update parseHTMLNonNegativeInteger() to return an unsigned value
https://bugs.webkit.org/show_bug.cgi?id=161759
Modified: trunk/Source/WebCore/html/HTMLImageElement.idl (205664 => 205665)
--- trunk/Source/WebCore/html/HTMLImageElement.idl 2016-09-08 22:00:52 UTC (rev 205664)
+++ trunk/Source/WebCore/html/HTMLImageElement.idl 2016-09-08 22:02:39 UTC (rev 205665)
@@ -28,7 +28,7 @@
[Reflect, TreatNullAs=EmptyString] attribute DOMString border;
attribute DOMString? crossOrigin;
attribute unsigned long height;
- [Reflect] attribute long hspace;
+ [Reflect] attribute unsigned long hspace;
[Reflect] attribute boolean isMap;
[Reflect, URL] attribute USVString longDesc;
[Reflect, URL] attribute USVString src;
@@ -36,7 +36,7 @@
[Reflect] attribute DOMString sizes;
readonly attribute USVString currentSrc;
[Reflect] attribute DOMString useMap;
- [Reflect] attribute long vspace;
+ [Reflect] attribute unsigned long vspace;
attribute unsigned long width;
// Extensions
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
