Title: [205688] trunk/Source/WebKit2
Revision
205688
Author
[email protected]
Date
2016-09-08 19:50:02 -0700 (Thu, 08 Sep 2016)

Log Message

Re-landing the fix for

[Mac] .tbd files for the shims end up installed when building with GENERATE_TEXT_BASED_STUBS=YES
https://bugs.webkit.org/show_bug.cgi?id=161722

without reintroducing https://webkit.org/b/161782

* Configurations/Shim.xcconfig: Don’t install the shims. The Copy Shims build phase in the
  WebKit target will copy them into place without bringing their .tbd files along. Keep the
  install path set, though, because it determines the dylibs’ install names.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (205687 => 205688)


--- trunk/Source/WebKit2/ChangeLog	2016-09-09 02:25:10 UTC (rev 205687)
+++ trunk/Source/WebKit2/ChangeLog	2016-09-09 02:50:02 UTC (rev 205688)
@@ -1,3 +1,16 @@
+2016-09-08  Dan Bernstein  <[email protected]>
+
+        Re-landing the fix for
+
+        [Mac] .tbd files for the shims end up installed when building with GENERATE_TEXT_BASED_STUBS=YES
+        https://bugs.webkit.org/show_bug.cgi?id=161722
+
+        without reintroducing https://webkit.org/b/161782
+
+        * Configurations/Shim.xcconfig: Don’t install the shims. The Copy Shims build phase in the
+          WebKit target will copy them into place without bringing their .tbd files along. Keep the
+          install path set, though, because it determines the dylibs’ install names.
+
 2016-09-08  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r205576.

Modified: trunk/Source/WebKit2/Configurations/Shim.xcconfig (205687 => 205688)


--- trunk/Source/WebKit2/Configurations/Shim.xcconfig	2016-09-09 02:25:10 UTC (rev 205687)
+++ trunk/Source/WebKit2/Configurations/Shim.xcconfig	2016-09-09 02:50:02 UTC (rev 205688)
@@ -25,6 +25,5 @@
 
 GCC_DYNAMIC_NO_PIC = NO;
 SKIP_INSTALL = YES;
-SKIP_INSTALL[sdk=macosx*] = NO;
 
 INSTALL_PATH = $(WEBKIT_FRAMEWORKS_DIR)/WebKit.framework/Versions/A/Frameworks;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to