Title: [205736] releases/WebKitGTK/webkit-2.14/Source/WebKit2
- Revision
- 205736
- Author
- [email protected]
- Date
- 2016-09-09 03:55:11 -0700 (Fri, 09 Sep 2016)
Log Message
Merge r205547 - [GTK] Clarify frame callbacks behaviour in Wayland compositor
https://bugs.webkit.org/show_bug.cgi?id=161683
Patch by Emanuele Aina <[email protected]> on 2016-09-07
Reviewed by Carlos Garcia Campos.
The way we fire frame callbacks in the nested Wayland compositor can
be puzzling to developers expecting Wayland semantics, but since we
have our own mechanism to handle synchronization we don't care much
about them. Add a comment to avoid surprised Wayland developers.
* UIProcess/gtk/WaylandCompositor.cpp:
(WebKit::WaylandCompositor::Surface::commit):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog (205735 => 205736)
--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2016-09-09 10:54:33 UTC (rev 205735)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/ChangeLog 2016-09-09 10:55:11 UTC (rev 205736)
@@ -1,3 +1,18 @@
+2016-09-07 Emanuele Aina <[email protected]>
+
+ [GTK] Clarify frame callbacks behaviour in Wayland compositor
+ https://bugs.webkit.org/show_bug.cgi?id=161683
+
+ Reviewed by Carlos Garcia Campos.
+
+ The way we fire frame callbacks in the nested Wayland compositor can
+ be puzzling to developers expecting Wayland semantics, but since we
+ have our own mechanism to handle synchronization we don't care much
+ about them. Add a comment to avoid surprised Wayland developers.
+
+ * UIProcess/gtk/WaylandCompositor.cpp:
+ (WebKit::WaylandCompositor::Surface::commit):
+
2016-09-06 Carlos Garcia Campos <[email protected]>
[GTK][Threaded Compositor] Several flaky tests
Modified: releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp (205735 => 205736)
--- releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp 2016-09-09 10:54:33 UTC (rev 205735)
+++ releases/WebKitGTK/webkit-2.14/Source/WebKit2/UIProcess/gtk/WaylandCompositor.cpp 2016-09-09 10:55:11 UTC (rev 205736)
@@ -231,6 +231,10 @@
if (m_webPage)
m_webPage->setViewNeedsDisplay(IntRect(IntPoint::zero(), m_webPage->viewSize()));
+ // From a Wayland point-of-view frame callbacks should be fired where the
+ // compositor knows it has *used* the committed contents, so firing them here
+ // can be surprising but we don't need them as a throttling mechanism because
+ // rendering synchronization is handled elsewhere by WebKit.
auto list = WTFMove(m_frameCallbackList);
for (auto* resource : list) {
wl_callback_send_done(resource, 0);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
