Title: [98457] trunk/LayoutTests
Revision
98457
Author
[email protected]
Date
2011-10-26 02:33:51 -0700 (Wed, 26 Oct 2011)

Log Message

Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
https://bugs.webkit.org/show_bug.cgi?id=70880

Reviewed by Eric Seidel.

Use option key (instead of control key) to move between word boundaries on Mac.

* editing/selection/caret-mode-paragraph-keys-navigation.html:
* platform/chromium/test_expectations.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (98456 => 98457)


--- trunk/LayoutTests/ChangeLog	2011-10-26 09:25:39 UTC (rev 98456)
+++ trunk/LayoutTests/ChangeLog	2011-10-26 09:33:51 UTC (rev 98457)
@@ -1,3 +1,15 @@
+2011-10-26  Ryosuke Niwa  <[email protected]>
+
+        Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac
+        https://bugs.webkit.org/show_bug.cgi?id=70880
+
+        Reviewed by Eric Seidel.
+
+        Use option key (instead of control key) to move between word boundaries on Mac.
+
+        * editing/selection/caret-mode-paragraph-keys-navigation.html:
+        * platform/chromium/test_expectations.txt:
+
 2011-10-26  Pavel Feldman  <[email protected]>
 
         Web Inspector: order console message parameters for better optional parameters handling.

Modified: trunk/LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html (98456 => 98457)


--- trunk/LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html	2011-10-26 09:25:39 UTC (rev 98456)
+++ trunk/LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html	2011-10-26 09:33:51 UTC (rev 98457)
@@ -39,18 +39,19 @@
   shouldBe("getSelection().baseOffset", "15");
   shouldBe("getSelection().extentOffset", "17");
 
-  // check left/right arrows + Ctrl
-  eventSender.keyDown("rightArrow", ["ctrlKey"]);
+  // check left/right arrows + Ctrl/Option
+  var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey";
+  eventSender.keyDown("rightArrow", [modifierForWordGranularity]);
   shouldBe("getSelection().baseOffset", "21");
-  eventSender.keyDown("leftArrow", ["ctrlKey"]);
+  eventSender.keyDown("leftArrow", [modifierForWordGranularity]);
   shouldBe("getSelection().baseOffset", "16");
 
-  // check left/right arrows + Ctrl + Shift
-  eventSender.keyDown("rightArrow", ["ctrlKey", "shiftKey"]);
-  eventSender.keyDown("rightArrow", ["ctrlKey", "shiftKey"]);
+  // check left/right arrows + Ctrl/Option + Shift
+  eventSender.keyDown("rightArrow", [modifierForWordGranularity, "shiftKey"]);
+  eventSender.keyDown("rightArrow", [modifierForWordGranularity, "shiftKey"]);
   shouldBe("getSelection().baseOffset", "16");
   shouldBe("getSelection().extentOffset", "26");
-  eventSender.keyDown("leftArrow", ["ctrlKey"]);
+  eventSender.keyDown("leftArrow", [modifierForWordGranularity]);
   shouldBe("getSelection().baseOffset", "22");
 }
 

Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (98456 => 98457)


--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 09:25:39 UTC (rev 98456)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-10-26 09:33:51 UTC (rev 98457)
@@ -2480,7 +2480,6 @@
 BUGCR67442 LINUX WIN : fast/canvas/fillText-shadow.html = TEXT
 
 BUGWK51720 DEBUG : http/tests/incremental/split-hex-entities.pl = PASS CRASH
-BUGCR67463 MAC : editing/selection/caret-mode-paragraph-keys-navigation.html = TEXT
 
 BUGCR68436 LINUX DEBUG : fast/dom/DOMImplementation/createDocument-with-used-doctype.html = PASS TIMEOUT
 BUGCR68436 MAC WIN DEBUG : fast/dom/DOMImplementation/createDocument-with-used-doctype.html = PASS TIMEOUT TEXT
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to