Title: [205814] trunk/Source/WebCore
Revision
205814
Author
[email protected]
Date
2016-09-12 11:18:05 -0700 (Mon, 12 Sep 2016)

Log Message

Crash in com.apple.WebCore: WebCore::NavigatorGamepad::gamepadFromPlatformGamepad.
<rdar://problem/28018073> and https://bugs.webkit.org/show_bug.cgi?id=161694

Reviewed by Alex Christensen.

No new tests (Caught by existing tests in some configurations).

* Modules/gamepad/GamepadManager.cpp:
(WebCore::GamepadManager::platformGamepadInputActivity): Null check.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (205813 => 205814)


--- trunk/Source/WebCore/ChangeLog	2016-09-12 18:10:24 UTC (rev 205813)
+++ trunk/Source/WebCore/ChangeLog	2016-09-12 18:18:05 UTC (rev 205814)
@@ -1,3 +1,15 @@
+2016-09-12  Brady Eidson  <[email protected]>
+
+        Crash in com.apple.WebCore: WebCore::NavigatorGamepad::gamepadFromPlatformGamepad.
+        <rdar://problem/28018073> and https://bugs.webkit.org/show_bug.cgi?id=161694
+
+        Reviewed by Alex Christensen.
+
+        No new tests (Caught by existing tests in some configurations).
+
+        * Modules/gamepad/GamepadManager.cpp:
+        (WebCore::GamepadManager::platformGamepadInputActivity): Null check.
+
 2016-09-12  Alex Christensen  <[email protected]>
 
         Fix more URLParser quirks

Modified: trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp (205813 => 205814)


--- trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp	2016-09-12 18:10:24 UTC (rev 205813)
+++ trunk/Source/WebCore/Modules/gamepad/GamepadManager.cpp	2016-09-12 18:18:05 UTC (rev 205814)
@@ -120,8 +120,10 @@
     if (m_gamepadBlindNavigators.isEmpty() && m_gamepadBlindDOMWindows.isEmpty())
         return;
 
-    for (auto* gamepad : GamepadProvider::singleton().platformGamepads())
-        makeGamepadVisible(*gamepad, m_gamepadBlindNavigators, m_gamepadBlindDOMWindows);
+    for (auto* gamepad : GamepadProvider::singleton().platformGamepads()) {
+        if (gamepad)
+            makeGamepadVisible(*gamepad, m_gamepadBlindNavigators, m_gamepadBlindDOMWindows);
+    }
 
     m_gamepadBlindNavigators.clear();
     m_gamepadBlindDOMWindows.clear();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to