Title: [205839] trunk
- Revision
- 205839
- Author
- [email protected]
- Date
- 2016-09-12 16:33:58 -0700 (Mon, 12 Sep 2016)
Log Message
HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
https://bugs.webkit.org/show_bug.cgi?id=161874
Patch by Joseph Pecoraro <[email protected]> on 2016-09-12
Reviewed by Chris Dumez.
Source/WebCore:
Test: fast/dom/HTMLButtonElement/click.html
* html/HTMLButtonElement.idl:
Remove the unnecessary 'click' definition. It already exists in HTMLElement.
If this was needed for ObjC code generation on DOMHTMLButtonElement, then
the extra definition is no longer needed now that ObjC bindings have moved.
LayoutTests:
* fast/dom/HTMLButtonElement/click-expected.txt: Added.
* fast/dom/HTMLButtonElement/click.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (205838 => 205839)
--- trunk/LayoutTests/ChangeLog 2016-09-12 23:14:25 UTC (rev 205838)
+++ trunk/LayoutTests/ChangeLog 2016-09-12 23:33:58 UTC (rev 205839)
@@ -1,3 +1,13 @@
+2016-09-12 Joseph Pecoraro <[email protected]>
+
+ HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
+ https://bugs.webkit.org/show_bug.cgi?id=161874
+
+ Reviewed by Chris Dumez.
+
+ * fast/dom/HTMLButtonElement/click-expected.txt: Added.
+ * fast/dom/HTMLButtonElement/click.html: Added.
+
2016-09-12 Ryan Haddad <[email protected]>
Marking imported/w3c/web-platform-tests/dom/nodes/ProcessingInstruction-escapes-1.xhtml as flaky on mac.
Added: trunk/LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt (0 => 205839)
--- trunk/LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLButtonElement/click-expected.txt 2016-09-12 23:33:58 UTC (rev 205839)
@@ -0,0 +1,10 @@
+Tests HTMLButtonElement's click is just HTMLElement click
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS HTMLElement.prototype.click is HTMLButtonElement.prototype.click
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/dom/HTMLButtonElement/click.html (0 => 205839)
--- trunk/LayoutTests/fast/dom/HTMLButtonElement/click.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLButtonElement/click.html 2016-09-12 23:33:58 UTC (rev 205839)
@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Tests HTMLButtonElement's click is just HTMLElement click");
+shouldBe("HTMLElement.prototype.click", "HTMLButtonElement.prototype.click");
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (205838 => 205839)
--- trunk/Source/WebCore/ChangeLog 2016-09-12 23:14:25 UTC (rev 205838)
+++ trunk/Source/WebCore/ChangeLog 2016-09-12 23:33:58 UTC (rev 205839)
@@ -1,3 +1,17 @@
+2016-09-12 Joseph Pecoraro <[email protected]>
+
+ HTMLButtonElement.prototype.click should be HTMLElement.prototype.click
+ https://bugs.webkit.org/show_bug.cgi?id=161874
+
+ Reviewed by Chris Dumez.
+
+ Test: fast/dom/HTMLButtonElement/click.html
+
+ * html/HTMLButtonElement.idl:
+ Remove the unnecessary 'click' definition. It already exists in HTMLElement.
+ If this was needed for ObjC code generation on DOMHTMLButtonElement, then
+ the extra definition is no longer needed now that ObjC bindings have moved.
+
2016-09-12 Alex Christensen <[email protected]>
URLParser: Fix relative URLs containing only fragments
Modified: trunk/Source/WebCore/html/HTMLButtonElement.idl (205838 => 205839)
--- trunk/Source/WebCore/html/HTMLButtonElement.idl 2016-09-12 23:14:25 UTC (rev 205838)
+++ trunk/Source/WebCore/html/HTMLButtonElement.idl 2016-09-12 23:33:58 UTC (rev 205839)
@@ -40,6 +40,4 @@
void setCustomValidity(DOMString? error);
readonly attribute NodeList labels;
-
- void click();
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
