Title: [205867] trunk/Source/WebCore
- Revision
- 205867
- Author
- [email protected]
- Date
- 2016-09-13 12:01:04 -0700 (Tue, 13 Sep 2016)
Log Message
Organize CSS keyword properties in WebCore::isKeywordPropertyID()
https://bugs.webkit.org/show_bug.cgi?id=161917
Reviewed by Simon Fraser.
Group and sort compile-time feature keywords and move them to the end of the switch block
to avoid the distraction of preprocessor statements scattered throughout the list. Sort
all the other keyword properties to make it straightforward to find a property by name.
* css/parser/CSSParser.cpp:
(WebCore::isKeywordPropertyID):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205866 => 205867)
--- trunk/Source/WebCore/ChangeLog 2016-09-13 18:37:12 UTC (rev 205866)
+++ trunk/Source/WebCore/ChangeLog 2016-09-13 19:01:04 UTC (rev 205867)
@@ -1,3 +1,17 @@
+2016-09-13 Daniel Bates <[email protected]>
+
+ Organize CSS keyword properties in WebCore::isKeywordPropertyID()
+ https://bugs.webkit.org/show_bug.cgi?id=161917
+
+ Reviewed by Simon Fraser.
+
+ Group and sort compile-time feature keywords and move them to the end of the switch block
+ to avoid the distraction of preprocessor statements scattered throughout the list. Sort
+ all the other keyword properties to make it straightforward to find a property by name.
+
+ * css/parser/CSSParser.cpp:
+ (WebCore::isKeywordPropertyID):
+
2016-09-13 Nan Wang <[email protected]>
AX: Crash at AccessibilityRenderObject::computeAccessibilityIsIgnored const + 552
Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (205866 => 205867)
--- trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-09-13 18:37:12 UTC (rev 205866)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp 2016-09-13 19:01:04 UTC (rev 205867)
@@ -1051,11 +1051,18 @@
case CSSPropertyBreakInside:
case CSSPropertyCaptionSide:
case CSSPropertyClear:
+ case CSSPropertyColumnFill:
+ case CSSPropertyColumnRuleStyle:
case CSSPropertyDirection:
case CSSPropertyDisplay:
case CSSPropertyEmptyCells:
+ case CSSPropertyFlexDirection:
+ case CSSPropertyFlexWrap:
case CSSPropertyFloat:
case CSSPropertyFontStyle:
+ case CSSPropertyFontVariantAlternates:
+ case CSSPropertyFontVariantCaps:
+ case CSSPropertyFontVariantPosition:
case CSSPropertyImageRendering:
case CSSPropertyListStylePosition:
case CSSPropertyListStyleType:
@@ -1081,12 +1088,9 @@
case CSSPropertyTextTransform:
case CSSPropertyTextUnderlineMode:
case CSSPropertyTextUnderlineStyle:
+ case CSSPropertyTransformStyle:
case CSSPropertyVisibility:
case CSSPropertyWebkitAppearance:
-#if ENABLE(CSS_COMPOSITING)
- case CSSPropertyMixBlendMode:
- case CSSPropertyIsolation:
-#endif
case CSSPropertyWebkitBackfaceVisibility:
case CSSPropertyWebkitBorderAfterStyle:
case CSSPropertyWebkitBorderBeforeStyle:
@@ -1094,9 +1098,6 @@
case CSSPropertyWebkitBorderFit:
case CSSPropertyWebkitBorderStartStyle:
case CSSPropertyWebkitBoxAlign:
-#if ENABLE(CSS_BOX_DECORATION_BREAK)
- case CSSPropertyWebkitBoxDecorationBreak:
-#endif
case CSSPropertyWebkitBoxDirection:
case CSSPropertyWebkitBoxLines:
case CSSPropertyWebkitBoxOrient:
@@ -1104,10 +1105,6 @@
case CSSPropertyWebkitColumnBreakAfter:
case CSSPropertyWebkitColumnBreakBefore:
case CSSPropertyWebkitColumnBreakInside:
- case CSSPropertyColumnFill:
- case CSSPropertyColumnRuleStyle:
- case CSSPropertyFlexDirection:
- case CSSPropertyFlexWrap:
case CSSPropertyWebkitFontKerning:
case CSSPropertyWebkitFontSmoothing:
case CSSPropertyWebkitHyphens:
@@ -1121,27 +1118,11 @@
case CSSPropertyWebkitMarqueeDirection:
case CSSPropertyWebkitMarqueeStyle:
case CSSPropertyWebkitNbspMode:
-#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
- case CSSPropertyWebkitOverflowScrolling:
-#endif
case CSSPropertyWebkitPrintColorAdjust:
-#if ENABLE(CSS_REGIONS)
- case CSSPropertyWebkitRegionBreakAfter:
- case CSSPropertyWebkitRegionBreakBefore:
- case CSSPropertyWebkitRegionBreakInside:
- case CSSPropertyWebkitRegionFragment:
-#endif
case CSSPropertyWebkitRtlOrdering:
case CSSPropertyWebkitRubyPosition:
-#if ENABLE(CSS3_TEXT)
- case CSSPropertyWebkitTextAlignLast:
-#endif // CSS3_TEXT
case CSSPropertyWebkitTextCombine:
-#if ENABLE(CSS3_TEXT)
- case CSSPropertyWebkitTextJustify:
-#endif // CSS3_TEXT
case CSSPropertyWebkitTextSecurity:
- case CSSPropertyTransformStyle:
case CSSPropertyWebkitTransformStyle:
case CSSPropertyWebkitUserDrag:
case CSSPropertyWebkitUserModify:
@@ -1150,18 +1131,35 @@
case CSSPropertyWhiteSpace:
case CSSPropertyWordBreak:
case CSSPropertyWordWrap:
+#if ENABLE(CSS_TRAILING_WORD)
+ case CSSPropertyAppleTrailingWord:
+#endif
+#if ENABLE(CSS_COMPOSITING)
+ case CSSPropertyIsolation:
+ case CSSPropertyMixBlendMode:
+#endif
#if ENABLE(TOUCH_EVENTS)
case CSSPropertyTouchAction:
#endif
+#if ENABLE(CSS_BOX_DECORATION_BREAK)
+ case CSSPropertyWebkitBoxDecorationBreak:
+#endif
+#if ENABLE(ACCELERATED_OVERFLOW_SCROLLING)
+ case CSSPropertyWebkitOverflowScrolling:
+#endif
+#if ENABLE(CSS_REGIONS)
+ case CSSPropertyWebkitRegionBreakAfter:
+ case CSSPropertyWebkitRegionBreakBefore:
+ case CSSPropertyWebkitRegionBreakInside:
+ case CSSPropertyWebkitRegionFragment:
+#endif
+#if ENABLE(CSS3_TEXT)
+ case CSSPropertyWebkitTextAlignLast:
+ case CSSPropertyWebkitTextJustify:
+#endif
#if ENABLE(CSS_SCROLL_SNAP)
case CSSPropertyWebkitScrollSnapType:
#endif
-#if ENABLE(CSS_TRAILING_WORD)
- case CSSPropertyAppleTrailingWord:
-#endif
- case CSSPropertyFontVariantPosition:
- case CSSPropertyFontVariantCaps:
- case CSSPropertyFontVariantAlternates:
return true;
case CSSPropertyJustifyContent:
case CSSPropertyAlignContent:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
