Title: [205886] trunk/Source/_javascript_Core
- Revision
- 205886
- Author
- [email protected]
- Date
- 2016-09-13 16:19:48 -0700 (Tue, 13 Sep 2016)
Log Message
Remove Heap::isLive()
https://bugs.webkit.org/show_bug.cgi?id=161933
Reviewed by Mark Lam.
Before I put any more effort into maintaining this weird function, I decided to check how it
was used. It turns out it's not.
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::isLive): Deleted.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (205885 => 205886)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-13 23:13:51 UTC (rev 205885)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-13 23:19:48 UTC (rev 205886)
@@ -1,3 +1,17 @@
+2016-09-13 Filip Pizlo <[email protected]>
+
+ Remove Heap::isLive()
+ https://bugs.webkit.org/show_bug.cgi?id=161933
+
+ Reviewed by Mark Lam.
+
+ Before I put any more effort into maintaining this weird function, I decided to check how it
+ was used. It turns out it's not.
+
+ * heap/Heap.h:
+ * heap/HeapInlines.h:
+ (JSC::Heap::isLive): Deleted.
+
2016-09-13 Mark Lam <[email protected]>
DFG NewArrayBuffer node should watch for "have a bad time" state change.
Modified: trunk/Source/_javascript_Core/heap/Heap.h (205885 => 205886)
--- trunk/Source/_javascript_Core/heap/Heap.h 2016-09-13 23:13:51 UTC (rev 205885)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2016-09-13 23:19:48 UTC (rev 205886)
@@ -97,7 +97,6 @@
// our scan to run faster.
static const unsigned s_timeCheckResolution = 16;
- static bool isLive(const void*);
static bool isMarked(const void*);
static bool isMarkedConcurrently(const void*);
static bool testAndSetMarked(HeapVersion, const void*);
Modified: trunk/Source/_javascript_Core/heap/HeapInlines.h (205885 => 205886)
--- trunk/Source/_javascript_Core/heap/HeapInlines.h 2016-09-13 23:13:51 UTC (rev 205885)
+++ trunk/Source/_javascript_Core/heap/HeapInlines.h 2016-09-13 23:19:48 UTC (rev 205886)
@@ -74,17 +74,6 @@
return heap(v.asCell());
}
-inline bool Heap::isLive(const void* rawCell)
-{
- ASSERT(!mayBeGCThread());
- HeapCell* cell = bitwise_cast<HeapCell*>(rawCell);
- if (cell->isLargeAllocation())
- return cell->largeAllocation().isLive();
- MarkedBlock& block = cell->markedBlock();
- block.flipIfNecessary(block.vm()->heap.objectSpace().version());
- return block.handle().isLiveCell(cell);
-}
-
ALWAYS_INLINE bool Heap::isMarked(const void* rawCell)
{
ASSERT(!mayBeGCThread());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
