Title: [205913] trunk/Source/WebCore
- Revision
- 205913
- Author
- [email protected]
- Date
- 2016-09-14 09:56:34 -0700 (Wed, 14 Sep 2016)
Log Message
Regression(r152725): generate-bindings.pl --write-dependencies does not work
https://bugs.webkit.org/show_bug.cgi?id=161897
Reviewed by Darin Adler.
r152725 inadvertently dropped the code generating the JS*.dep files when
--write-dependencies is passed to the bindings generator. As a result,
our dependency tracking was broken. This patch restores the code that
was dropped in r152725.
* bindings/scripts/CodeGeneratorJS.pm:
(new):
(GenerateHeader):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (205912 => 205913)
--- trunk/Source/WebCore/ChangeLog 2016-09-14 16:56:06 UTC (rev 205912)
+++ trunk/Source/WebCore/ChangeLog 2016-09-14 16:56:34 UTC (rev 205913)
@@ -1,5 +1,21 @@
2016-09-14 Chris Dumez <[email protected]>
+ Regression(r152725): generate-bindings.pl --write-dependencies does not work
+ https://bugs.webkit.org/show_bug.cgi?id=161897
+
+ Reviewed by Darin Adler.
+
+ r152725 inadvertently dropped the code generating the JS*.dep files when
+ --write-dependencies is passed to the bindings generator. As a result,
+ our dependency tracking was broken. This patch restores the code that
+ was dropped in r152725.
+
+ * bindings/scripts/CodeGeneratorJS.pm:
+ (new):
+ (GenerateHeader):
+
+2016-09-14 Chris Dumez <[email protected]>
+
input.type cannot be set to "file" after being set to another type
https://bugs.webkit.org/show_bug.cgi?id=161943
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (205912 => 205913)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-09-14 16:56:06 UTC (rev 205912)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2016-09-14 16:56:34 UTC (rev 205913)
@@ -36,6 +36,7 @@
use Hasher;
my $codeGenerator;
+my $writeDependencies;
my @headerContentHeader = ();
my @headerContent = ();
@@ -113,6 +114,7 @@
my $reference = { };
$codeGenerator = shift;
+ $writeDependencies = shift;
bless($reference, $object);
return $reference;
@@ -1600,6 +1602,17 @@
push(@headerContent, "\n");
push(@headerContent, split("\r", $endAppleCopyright));
}
+
+ # - Generate dependencies.
+ if ($writeDependencies) {
+ my @ancestors;
+ $codeGenerator->ForAllParents($interface, sub {
+ my $currentInterface = shift;
+ push(@ancestors, $currentInterface->name);
+ }, 0);
+ push(@depsContent, "$className.h : ", join(" ", map { "$_.idl" } @ancestors), "\n");
+ push(@depsContent, map { "$_.idl :\n" } @ancestors);
+ }
}
sub GeneratePropertiesHashTable
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
