Title: [205925] trunk/Source/_javascript_Core
- Revision
- 205925
- Author
- [email protected]
- Date
- 2016-09-14 13:41:31 -0700 (Wed, 14 Sep 2016)
Log Message
Remove Heap::setMarked()
Rubber stamped by Keith Miller.
Nobody uses this function.
* heap/Heap.h:
* heap/HeapInlines.h:
(JSC::Heap::setMarked): Deleted.
* heap/LargeAllocation.h:
(JSC::LargeAllocation::testAndSetMarked):
(JSC::LargeAllocation::setMarked): Deleted.
* heap/MarkedBlock.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (205924 => 205925)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-14 20:12:14 UTC (rev 205924)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-14 20:41:31 UTC (rev 205925)
@@ -1,3 +1,19 @@
+2016-09-14 Filip Pizlo <[email protected]>
+
+ Remove Heap::setMarked()
+
+ Rubber stamped by Keith Miller.
+
+ Nobody uses this function.
+
+ * heap/Heap.h:
+ * heap/HeapInlines.h:
+ (JSC::Heap::setMarked): Deleted.
+ * heap/LargeAllocation.h:
+ (JSC::LargeAllocation::testAndSetMarked):
+ (JSC::LargeAllocation::setMarked): Deleted.
+ * heap/MarkedBlock.h:
+
2016-09-14 Mark Lam <[email protected]>
Use Options::validateExceptionChecks() instead of VM::m_verifyExceptionEvents.
Modified: trunk/Source/_javascript_Core/heap/Heap.h (205924 => 205925)
--- trunk/Source/_javascript_Core/heap/Heap.h 2016-09-14 20:12:14 UTC (rev 205924)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2016-09-14 20:41:31 UTC (rev 205925)
@@ -100,7 +100,6 @@
static bool isMarked(const void*);
static bool isMarkedConcurrently(const void*);
static bool testAndSetMarked(HeapVersion, const void*);
- static void setMarked(const void*);
static size_t cellSize(const void*);
Modified: trunk/Source/_javascript_Core/heap/HeapInlines.h (205924 => 205925)
--- trunk/Source/_javascript_Core/heap/HeapInlines.h 2016-09-14 20:12:14 UTC (rev 205924)
+++ trunk/Source/_javascript_Core/heap/HeapInlines.h 2016-09-14 20:41:31 UTC (rev 205925)
@@ -108,18 +108,6 @@
return block.testAndSetMarked(cell);
}
-inline void Heap::setMarked(const void* rawCell)
-{
- HeapCell* cell = bitwise_cast<HeapCell*>(rawCell);
- if (cell->isLargeAllocation()) {
- cell->largeAllocation().setMarked();
- return;
- }
- MarkedBlock& block = cell->markedBlock();
- block.flipIfNecessary(block.vm()->heap.objectSpace().version());
- block.setMarked(cell);
-}
-
ALWAYS_INLINE size_t Heap::cellSize(const void* rawCell)
{
return bitwise_cast<HeapCell*>(rawCell)->cellSize();
Modified: trunk/Source/_javascript_Core/heap/LargeAllocation.h (205924 => 205925)
--- trunk/Source/_javascript_Core/heap/LargeAllocation.h 2016-09-14 20:12:14 UTC (rev 205924)
+++ trunk/Source/_javascript_Core/heap/LargeAllocation.h 2016-09-14 20:41:31 UTC (rev 205925)
@@ -119,7 +119,6 @@
return !m_isMarked.compareExchangeStrong(false, true);
}
ALWAYS_INLINE bool testAndSetMarked(HeapCell*) { return testAndSetMarked(); }
- void setMarked() { m_isMarked.store(true); }
void clearMarked() { m_isMarked.store(false); }
void noteMarked() { }
Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.h (205924 => 205925)
--- trunk/Source/_javascript_Core/heap/MarkedBlock.h 2016-09-14 20:12:14 UTC (rev 205924)
+++ trunk/Source/_javascript_Core/heap/MarkedBlock.h 2016-09-14 20:41:31 UTC (rev 205925)
@@ -254,7 +254,6 @@
bool isMarkedOrNewlyAllocatedDuringWeakVisiting(HeapVersion, const HeapCell*);
bool isAtom(const void*);
- void setMarked(const void*);
void clearMarked(const void*);
size_t cellSize();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
