Diff
Modified: trunk/LayoutTests/ChangeLog (205966 => 205967)
--- trunk/LayoutTests/ChangeLog 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/LayoutTests/ChangeLog 2016-09-15 11:18:08 UTC (rev 205967)
@@ -1,3 +1,14 @@
+2016-09-15 Csaba Osztrogonác <o...@webkit.org>
+
+ js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
+ https://bugs.webkit.org/show_bug.cgi?id=159807
+
+ Reviewed by Saam Barati.
+
+ * js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Skipped on memory limited devices.
+ * js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Skipped on memory limited devices.
+ * js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Skipped on memory limited devices.
+
2016-09-07 Sergio Villar Senin <svil...@igalia.com>
[css-grid] Implement fit-content track size
Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js (205966 => 205967)
--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js 2016-09-15 11:18:08 UTC (rev 205967)
@@ -1,3 +1,5 @@
+//@largeHeap
+
"use strict"
// Based on André Bargull's test case.
Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js (205966 => 205967)
--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js 2016-09-15 11:18:08 UTC (rev 205967)
@@ -1,3 +1,5 @@
+//@largeHeap
+
"use strict"
// Based on André Bargull's test case.
Modified: trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js (205966 => 205967)
--- trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/LayoutTests/js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js 2016-09-15 11:18:08 UTC (rev 205967)
@@ -1,3 +1,5 @@
+//@largeHeap
+
"use strict"
// This test passes if it does not crash.
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (205966 => 205967)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg 2016-09-15 11:18:08 UTC (rev 205967)
@@ -325,7 +325,7 @@
class RunRemoteJavaScriptCoreTests(RunJavaScriptCoreTests):
def start(self):
- self.setCommand(self.command + ["--remote-config-file", "../../remote-jsc-tests-config.json"])
+ self.setCommand(self.command + ["--memory-limited", "--remote-config-file", "../../remote-jsc-tests-config.json"])
return RunJavaScriptCoreTests.start(self)
Modified: trunk/Tools/ChangeLog (205966 => 205967)
--- trunk/Tools/ChangeLog 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/Tools/ChangeLog 2016-09-15 11:18:08 UTC (rev 205967)
@@ -1,3 +1,16 @@
+2016-09-15 Csaba Osztrogonác <o...@webkit.org>
+
+ js/stringimpl-to-jsstring-on-large-strings tests consume huge memory
+ https://bugs.webkit.org/show_bug.cgi?id=159807
+
+ Reviewed by Saam Barati.
+
+ * BuildSlaveSupport/build.webkit.org-config/master.cfg:
+ (RunRemoteJavaScriptCoreTests.start): JSCOnly bots are memory limited devices, tests should run with --memory-limited option.
+ * Scripts/run-_javascript_core-tests:
+ (runJSCStressTests): Pass through --memory-limited option to run-jsc-stress-tests.
+ * Scripts/run-jsc-stress-tests: Typo fix.
+
2016-09-14 Wenson Hsieh <wenson_hs...@apple.com>
Media controls behave strangely when changing media sources
Modified: trunk/Tools/Scripts/run-_javascript_core-tests (205966 => 205967)
--- trunk/Tools/Scripts/run-_javascript_core-tests 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/Tools/Scripts/run-_javascript_core-tests 2016-09-15 11:18:08 UTC (rev 205967)
@@ -52,6 +52,7 @@
my $childProcesses;
my $shellRunner;
my $makeRunner;
+my $memoryLimited;
my $buildJSC = 1;
@@ -131,6 +132,10 @@
--shell-runner Uses the shell-based test runner instead of the default make-based runner.
In general the shell runner is slower than the make runner.
--make-runner Uses the faster make-based runner.
+
+ --memory-limited Indicate that we are targeting the test for a memory limited device.
+ Skip tests tagged with //\@largeHeap
+
--filter Only run tests whose name matches the given regular _expression_.
--env-vars Pass a list of environment variables to set before running tests.
Each environment variable should be separated by a space.
@@ -160,6 +165,7 @@
'child-processes=s' => \$childProcesses,
'shell-runner' => \$shellRunner,
'make-runner' => \$makeRunner,
+ 'memory-limited' => \$memoryLimited,
'filter=s' => \$filter,
'help' => \$showHelp,
'env-vars=s' => \$envVars,
@@ -338,6 +344,10 @@
push(@jscStressDriverCmd, "--make-runner");
}
+ if ($memoryLimited) {
+ push(@jscStressDriverCmd, "--memory-limited");
+ }
+
if ($filter) {
push(@jscStressDriverCmd, "--filter");
push(@jscStressDriverCmd, $filter);
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (205966 => 205967)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2016-09-15 09:45:36 UTC (rev 205966)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2016-09-15 11:18:08 UTC (rev 205967)
@@ -125,7 +125,7 @@
puts "--no-copy Do not copy the _javascript_Core build product before testing."
puts " --jsc specifies an already present _javascript_Core to test."
puts "--memory-limited Indicate that we are targeting the test for a memory limited device."
- puts " Skip tests tagged with //@large-heap"
+ puts " Skip tests tagged with //@largeHeap"
puts "--no-jit Do not run JIT specific tests."
puts "--output-dir (-o) Path where to put results. Default is #{$outputDir}."
puts "--verbose (-v) Print more things while running."
