Title: [205998] trunk/Source/_javascript_Core
Revision
205998
Author
[email protected]
Date
2016-09-15 15:01:37 -0700 (Thu, 15 Sep 2016)

Log Message

REGRESSION (r205462): Lot of leaks
https://bugs.webkit.org/show_bug.cgi?id=161946

Reviewed by Saam Barati.
        
We were forgetting to delete LargeAllocations on VM exit!

* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (205997 => 205998)


--- trunk/Source/_javascript_Core/ChangeLog	2016-09-15 21:57:33 UTC (rev 205997)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-09-15 22:01:37 UTC (rev 205998)
@@ -1,3 +1,15 @@
+2016-09-15  Filip Pizlo  <[email protected]>
+
+        REGRESSION (r205462): Lot of leaks
+        https://bugs.webkit.org/show_bug.cgi?id=161946
+
+        Reviewed by Saam Barati.
+        
+        We were forgetting to delete LargeAllocations on VM exit!
+
+        * heap/MarkedSpace.cpp:
+        (JSC::MarkedSpace::~MarkedSpace):
+
 2016-09-15  Keith Miller  <[email protected]>
 
 

Modified: trunk/Source/_javascript_Core/heap/MarkedSpace.cpp (205997 => 205998)


--- trunk/Source/_javascript_Core/heap/MarkedSpace.cpp	2016-09-15 21:57:33 UTC (rev 205997)
+++ trunk/Source/_javascript_Core/heap/MarkedSpace.cpp	2016-09-15 22:01:37 UTC (rev 205998)
@@ -203,6 +203,8 @@
         [&] (MarkedBlock::Handle* block) {
             freeBlock(block);
         });
+    for (LargeAllocation* allocation : m_largeAllocations)
+        allocation->destroy();
     ASSERT(!m_blocks.set().size());
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to