Title: [206002] trunk/Source/WebKit/mac
Revision
206002
Author
[email protected]
Date
2016-09-15 16:34:31 -0700 (Thu, 15 Sep 2016)

Log Message

Replace use of Carbon file system APIs in plug-in loading
https://bugs.webkit.org/show_bug.cgi?id=162040
rdar://problem/6017896

Reviewed by Sam Weinig.

* Plugins/WebBasePluginPackage.mm:
(-[WebBasePluginPackage initWithPath:]):
Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (206001 => 206002)


--- trunk/Source/WebKit/mac/ChangeLog	2016-09-15 23:13:56 UTC (rev 206001)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-09-15 23:34:31 UTC (rev 206002)
@@ -1,3 +1,16 @@
+2016-09-15  Anders Carlsson  <[email protected]>
+
+        Replace use of Carbon file system APIs in plug-in loading
+        https://bugs.webkit.org/show_bug.cgi?id=162040
+        rdar://problem/6017896
+
+        Reviewed by Sam Weinig.
+
+        * Plugins/WebBasePluginPackage.mm:
+        (-[WebBasePluginPackage initWithPath:]):
+        Use -[NSString stringByResolvingSymlinksInPath] directly here. We already check for duplicate bundle IDs, so there's no need to try
+        to resolve aliases as well (and the modern WebKit plug-in implementation doesn't do this).
+
 2016-09-15  Beth Dakin  <[email protected]>
 
         Need hasMarkedText on Mac

Modified: trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm (206001 => 206002)


--- trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm	2016-09-15 23:13:56 UTC (rev 206001)
+++ trunk/Source/WebKit/mac/Plugins/WebBasePluginPackage.mm	2016-09-15 23:34:31 UTC (rev 206002)
@@ -123,8 +123,8 @@
 {
     if (!(self = [super init]))
         return nil;
-        
-    path = pathByResolvingSymlinksAndAliases(pluginPath);
+    
+    path = [pluginPath stringByResolvingSymlinksInPath];
     cfBundle = adoptCF(CFBundleCreate(kCFAllocatorDefault, (CFURLRef)[NSURL fileURLWithPath:path]));
 
     if (!cfBundle) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to