Title: [206069] releases/WebKitGTK/webkit-2.14/Source/_javascript_Core
Revision
206069
Author
carlo...@webkit.org
Date
2016-09-17 03:48:23 -0700 (Sat, 17 Sep 2016)

Log Message

Merge r205998 - REGRESSION (r205462): Lot of leaks
https://bugs.webkit.org/show_bug.cgi?id=161946

Reviewed by Saam Barati.

We were forgetting to delete LargeAllocations on VM exit!

* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::~MarkedSpace):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog (206068 => 206069)


--- releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog	2016-09-17 10:47:42 UTC (rev 206068)
+++ releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/ChangeLog	2016-09-17 10:48:23 UTC (rev 206069)
@@ -1,3 +1,15 @@
+2016-09-15  Filip Pizlo  <fpi...@apple.com>
+
+        REGRESSION (r205462): Lot of leaks
+        https://bugs.webkit.org/show_bug.cgi?id=161946
+
+        Reviewed by Saam Barati.
+        
+        We were forgetting to delete LargeAllocations on VM exit!
+
+        * heap/MarkedSpace.cpp:
+        (JSC::MarkedSpace::~MarkedSpace):
+
 2016-09-06  Saam Barati  <sbar...@apple.com>
 
         ProxyObject's structure should not have ObjectPrototype as its prototype and it should not have special behavior for intercepting "__proto__"

Modified: releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/heap/MarkedSpace.cpp (206068 => 206069)


--- releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/heap/MarkedSpace.cpp	2016-09-17 10:47:42 UTC (rev 206068)
+++ releases/WebKitGTK/webkit-2.14/Source/_javascript_Core/heap/MarkedSpace.cpp	2016-09-17 10:48:23 UTC (rev 206069)
@@ -203,6 +203,8 @@
         [&] (MarkedBlock::Handle* block) {
             freeBlock(block);
         });
+    for (LargeAllocation* allocation : m_largeAllocations)
+        allocation->destroy();
     ASSERT(!m_blocks.set().size());
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to