Title: [206108] trunk/Source/WebCore
Revision
206108
Author
commit-qu...@webkit.org
Date
2016-09-19 13:22:16 -0700 (Mon, 19 Sep 2016)

Log Message

Unreviewed, rolling out r206107.
https://bugs.webkit.org/show_bug.cgi?id=162229

still failing on armv7 for some reason (Requested by anttik on
#webkit).

Reverted changeset:

"Add size assert for RenderElement"
https://bugs.webkit.org/show_bug.cgi?id=162096
http://trac.webkit.org/changeset/206107

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (206107 => 206108)


--- trunk/Source/WebCore/ChangeLog	2016-09-19 19:26:31 UTC (rev 206107)
+++ trunk/Source/WebCore/ChangeLog	2016-09-19 20:22:16 UTC (rev 206108)
@@ -1,3 +1,17 @@
+2016-09-19  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r206107.
+        https://bugs.webkit.org/show_bug.cgi?id=162229
+
+        still failing on armv7 for some reason (Requested by anttik on
+        #webkit).
+
+        Reverted changeset:
+
+        "Add size assert for RenderElement"
+        https://bugs.webkit.org/show_bug.cgi?id=162096
+        http://trac.webkit.org/changeset/206107
+
 2016-09-19  Antti Koivisto  <an...@apple.com>
 
         Add size assert for RenderElement

Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (206107 => 206108)


--- trunk/Source/WebCore/rendering/RenderElement.cpp	2016-09-19 19:26:31 UTC (rev 206107)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2016-09-19 20:22:16 UTC (rev 206108)
@@ -78,15 +78,6 @@
 
 namespace WebCore {
 
-struct SameSizeAsRenderElement : public RenderObject {
-    uint32_t bitfields;
-    void* firstChild;
-    void* lastChild;
-    RenderStyle style;
-};
-
-static_assert(sizeof(RenderElement) == sizeof(SameSizeAsRenderElement), "RenderElement should stay small");
-
 bool RenderElement::s_affectsParentBlock = false;
 bool RenderElement::s_noLongerAffectsParentBlock = false;
     
@@ -1492,6 +1483,7 @@
     setIsRegisteredForVisibleInViewportCallback(false);
 
     view().unregisterForVisibleInViewportCallback(*this);
+    m_visibleInViewportState = VisibilityUnknown;
 }
 
 void RenderElement::visibleInViewportStateChanged(VisibleInViewportState state)

Modified: trunk/Source/WebCore/rendering/RenderElement.h (206107 => 206108)


--- trunk/Source/WebCore/rendering/RenderElement.h	2016-09-19 19:26:31 UTC (rev 206107)
+++ trunk/Source/WebCore/rendering/RenderElement.h	2016-09-19 20:22:16 UTC (rev 206108)
@@ -345,6 +345,8 @@
     unsigned m_renderBlockFlowHasMarkupTruncation : 1;
     unsigned m_renderBlockFlowLineLayoutPath : 2;
 
+    VisibleInViewportState m_visibleInViewportState { VisibilityUnknown };
+
     RenderObject* m_firstChild;
     RenderObject* m_lastChild;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to