Title: [206140] trunk
- Revision
- 206140
- Author
- [email protected]
- Date
- 2016-09-19 21:22:31 -0700 (Mon, 19 Sep 2016)
Log Message
Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
https://bugs.webkit.org/show_bug.cgi?id=162244
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline now that more checks are passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:
- https://html.spec.whatwg.org/#the-source-element
We already support the corresponding content attributes internally. However, we
are missing the corresponding IDL attributes that are supposed to reflect them.
Chrome and Firefox support them. We already had those IDL attributes on
HTMLImageElement.
No new tests, rebaselined existing test.
* html/HTMLSourceElement.idl:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206139 => 206140)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-20 04:22:31 UTC (rev 206140)
@@ -1,5 +1,16 @@
2016-09-19 Chris Dumez <[email protected]>
+ Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+ https://bugs.webkit.org/show_bug.cgi?id=162244
+
+ Reviewed by Alex Christensen.
+
+ Rebaseline now that more checks are passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
+2016-09-19 Chris Dumez <[email protected]>
+
Align HTMLAppletElement with the specification
https://bugs.webkit.org/show_bug.cgi?id=162240
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (206139 => 206140)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-20 04:22:31 UTC (rev 206140)
@@ -1405,7 +1405,7 @@
PASS HTMLHRElement interface: existence and properties of interface prototype object
PASS HTMLHRElement interface: existence and properties of interface prototype object's "constructor" property
PASS HTMLHRElement interface: attribute align
-FAIL HTMLHRElement interface: attribute color assert_true: The prototype object must have a property "color" expected true got false
+PASS HTMLHRElement interface: attribute color
PASS HTMLHRElement interface: attribute noShade
PASS HTMLHRElement interface: attribute size
PASS HTMLHRElement interface: attribute width
@@ -1412,7 +1412,7 @@
PASS HTMLHRElement must be primary interface of document.createElement("hr")
PASS Stringification of document.createElement("hr")
PASS HTMLHRElement interface: document.createElement("hr") must inherit property "align" with the proper type (0)
-FAIL HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1) assert_inherits: property "color" not found in prototype chain
+PASS HTMLHRElement interface: document.createElement("hr") must inherit property "color" with the proper type (1)
PASS HTMLHRElement interface: document.createElement("hr") must inherit property "noShade" with the proper type (2)
PASS HTMLHRElement interface: document.createElement("hr") must inherit property "size" with the proper type (3)
PASS HTMLHRElement interface: document.createElement("hr") must inherit property "width" with the proper type (4)
@@ -1950,15 +1950,15 @@
PASS HTMLSourceElement interface: existence and properties of interface prototype object's "constructor" property
PASS HTMLSourceElement interface: attribute src
PASS HTMLSourceElement interface: attribute type
-FAIL HTMLSourceElement interface: attribute srcset assert_true: The prototype object must have a property "srcset" expected true got false
-FAIL HTMLSourceElement interface: attribute sizes assert_true: The prototype object must have a property "sizes" expected true got false
+PASS HTMLSourceElement interface: attribute srcset
+PASS HTMLSourceElement interface: attribute sizes
PASS HTMLSourceElement interface: attribute media
PASS HTMLSourceElement must be primary interface of document.createElement("source")
PASS Stringification of document.createElement("source")
PASS HTMLSourceElement interface: document.createElement("source") must inherit property "src" with the proper type (0)
PASS HTMLSourceElement interface: document.createElement("source") must inherit property "type" with the proper type (1)
-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2) assert_inherits: property "srcset" not found in prototype chain
-FAIL HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3) assert_inherits: property "sizes" not found in prototype chain
+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "srcset" with the proper type (2)
+PASS HTMLSourceElement interface: document.createElement("source") must inherit property "sizes" with the proper type (3)
PASS HTMLSourceElement interface: document.createElement("source") must inherit property "media" with the proper type (4)
PASS HTMLTrackElement interface: existence and properties of interface object
PASS HTMLTrackElement interface object length
Modified: trunk/Source/WebCore/ChangeLog (206139 => 206140)
--- trunk/Source/WebCore/ChangeLog 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/Source/WebCore/ChangeLog 2016-09-20 04:22:31 UTC (rev 206140)
@@ -1,3 +1,23 @@
+2016-09-19 Chris Dumez <[email protected]>
+
+ Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset
+ https://bugs.webkit.org/show_bug.cgi?id=162244
+
+ Reviewed by Alex Christensen.
+
+ Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset:
+ - https://html.spec.whatwg.org/#the-source-element
+
+ We already support the corresponding content attributes internally. However, we
+ are missing the corresponding IDL attributes that are supposed to reflect them.
+
+ Chrome and Firefox support them. We already had those IDL attributes on
+ HTMLImageElement.
+
+ No new tests, rebaselined existing test.
+
+ * html/HTMLSourceElement.idl:
+
2016-09-19 Anders Carlsson <[email protected]>
Suppress _javascript_ prompts early on in certain cases
Modified: trunk/Source/WebCore/html/HTMLSourceElement.idl (206139 => 206140)
--- trunk/Source/WebCore/html/HTMLSourceElement.idl 2016-09-20 03:38:18 UTC (rev 206139)
+++ trunk/Source/WebCore/html/HTMLSourceElement.idl 2016-09-20 04:22:31 UTC (rev 206140)
@@ -24,7 +24,9 @@
*/
interface HTMLSourceElement : HTMLElement {
-[Reflect, URL] attribute USVString src;
-attribute DOMString type;
-attribute DOMString media;
+ [Reflect, URL] attribute USVString src;
+ attribute DOMString type;
+ [Reflect] attribute USVString srcset;
+ [Reflect] attribute DOMString sizes;
+ attribute DOMString media;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
