Title: [206169] trunk/Source/WebCore
- Revision
- 206169
- Author
- [email protected]
- Date
- 2016-09-20 13:25:03 -0700 (Tue, 20 Sep 2016)
Log Message
URLParser: uidna_IDNToASCII_56 is deprecated
https://bugs.webkit.org/show_bug.cgi?id=161841
Patch by Michael Catanzaro <[email protected]> on 2016-09-20
Reviewed by Alex Christensen.
Add pragmas to silence the warning, plus a FIXME.
* platform/URLParser.cpp:
(WebCore::domainToASCII):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206168 => 206169)
--- trunk/Source/WebCore/ChangeLog 2016-09-20 20:11:54 UTC (rev 206168)
+++ trunk/Source/WebCore/ChangeLog 2016-09-20 20:25:03 UTC (rev 206169)
@@ -1,3 +1,15 @@
+2016-09-20 Michael Catanzaro <[email protected]>
+
+ URLParser: uidna_IDNToASCII_56 is deprecated
+ https://bugs.webkit.org/show_bug.cgi?id=161841
+
+ Reviewed by Alex Christensen.
+
+ Add pragmas to silence the warning, plus a FIXME.
+
+ * platform/URLParser.cpp:
+ (WebCore::domainToASCII):
+
2016-09-20 Alex Christensen <[email protected]>
Make URLSearchParams spec-compliant
Modified: trunk/Source/WebCore/platform/URLParser.cpp (206168 => 206169)
--- trunk/Source/WebCore/platform/URLParser.cpp 2016-09-20 20:11:54 UTC (rev 206168)
+++ trunk/Source/WebCore/platform/URLParser.cpp 2016-09-20 20:25:03 UTC (rev 206169)
@@ -1971,8 +1971,16 @@
UChar hostnameBuffer[hostnameBufferLength];
UErrorCode error = U_ZERO_ERROR;
-
+
+#if COMPILER(GCC) || COMPILER(CLANG)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+#endif
+ // FIXME: This should use uidna_openUTS46 / uidna_close instead
int32_t numCharactersConverted = uidna_IDNToASCII(StringView(domain).upconvertedCharacters(), domain.length(), hostnameBuffer, hostnameBufferLength, UIDNA_ALLOW_UNASSIGNED, nullptr, &error);
+#if COMPILER(GCC) || COMPILER(CLANG)
+#pragma GCC diagnostic pop
+#endif
if (error == U_ZERO_ERROR) {
LChar buffer[hostnameBufferLength];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
