Diff
Modified: trunk/JSTests/ChangeLog (206170 => 206171)
--- trunk/JSTests/ChangeLog 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/ChangeLog 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,34 @@
+2016-09-20 Benjamin Poulain <bpoul...@apple.com>
+
+ [JSC] Do not use EagerRun on tests counting recompilation
+ https://bugs.webkit.org/show_bug.cgi?id=162248
+
+ Reviewed by Geoffrey Garen.
+
+ This patch adds defaultNoEagerRun to all the tests
+ for which recompilation is the symptom of a bug.
+ The reason is that an OSR Exit can be unrelated to the tested
+ nodes when we are running in Eager mode.
+
+ * stress/arith-abs-on-various-types.js:
+ * stress/arith-ceil-on-various-types.js:
+ * stress/arith-clz32-on-various-types.js:
+ * stress/arith-cos-on-various-types.js:
+ * stress/arith-floor-on-various-types.js:
+ * stress/arith-fround-on-various-types.js:
+ * stress/arith-log-on-various-types.js:
+ * stress/arith-round-on-various-types.js:
+ * stress/arith-sin-on-various-types.js:
+ * stress/arith-sqrt-on-various-types.js:
+ * stress/arith-tan-on-various-types.js:
+ * stress/arith-trunc-on-various-types.js:
+
+ * stress/compare-strict-eq-on-various-types.js:
+ (testAllTypesCall):
+ The value 2 came from the other tests.
+ CompareStrictEq supports many more cases, the worst case
+ is bool->int->int52->number->polymorphic.
+
2016-09-20 Filip Pizlo <fpi...@apple.com>
Make MarkedBlock state tracking support overlapped allocation and marking state
Modified: trunk/JSTests/stress/arith-abs-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-abs-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-abs-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-ceil-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-ceil-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-ceil-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-clz32-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-clz32-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-clz32-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-cos-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-cos-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-cos-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let cosOfFour = Math.cos(4);
Modified: trunk/JSTests/stress/arith-floor-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-floor-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-floor-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-fround-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-fround-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-fround-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let froundOfPi = Math.fround(Math.PI);
Modified: trunk/JSTests/stress/arith-log-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-log-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-log-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let logOfFour = Math.log(4);
Modified: trunk/JSTests/stress/arith-round-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-round-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-round-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-sin-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-sin-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-sin-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let sinOfFour = Math.sin(4);
Modified: trunk/JSTests/stress/arith-sqrt-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-sqrt-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-sqrt-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/arith-tan-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-tan-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-tan-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let tanOfFour = Math.tan(4);
Modified: trunk/JSTests/stress/arith-trunc-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/arith-trunc-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/arith-trunc-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
let validInputTestCases = [
Modified: trunk/JSTests/stress/compare-strict-eq-on-various-types.js (206170 => 206171)
--- trunk/JSTests/stress/compare-strict-eq-on-various-types.js 2016-09-20 20:44:26 UTC (rev 206170)
+++ trunk/JSTests/stress/compare-strict-eq-on-various-types.js 2016-09-20 20:57:31 UTC (rev 206171)
@@ -1,3 +1,4 @@
+//@ defaultNoEagerRun
"use strict";
function opaqueKitString() {
@@ -96,9 +97,9 @@
}
}
}
- if (numberOfDFGCompiles(opaqueStrictEqualAllTypes) > 2)
+ if (numberOfDFGCompiles(opaqueStrictEqualAllTypes) > 5)
throw "opaqueStrictEqualAllTypes() should have been quickly compiled as fully polymorphic.";
- if (opaqueStrictNotEqualAllTypes(opaqueStrictEqualAllTypes) > 2)
+ if (opaqueStrictNotEqualAllTypes(opaqueStrictEqualAllTypes) > 5)
throw "opaqueStrictEqualAllTypes() should have been quickly compiled as fully polymorphic.";
}
testAllTypesCall();