Title: [206179] trunk/Source/WebCore
Revision
206179
Author
achristen...@apple.com
Date
2016-09-20 15:19:16 -0700 (Tue, 20 Sep 2016)

Log Message

Fix occasional using uninitialized memory crashes after r206168.
https://bugs.webkit.org/show_bug.cgi?id=162247

This fixes a crash in imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
I could reproduce about 10% of the time.

* html/URLSearchParams.h:
Initialize the pointer to nullptr.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (206178 => 206179)


--- trunk/Source/WebCore/ChangeLog	2016-09-20 22:16:31 UTC (rev 206178)
+++ trunk/Source/WebCore/ChangeLog	2016-09-20 22:19:16 UTC (rev 206179)
@@ -1,5 +1,16 @@
 2016-09-20  Alex Christensen  <achristen...@webkit.org>
 
+        Fix occasional using uninitialized memory crashes after r206168.
+        https://bugs.webkit.org/show_bug.cgi?id=162247
+
+        This fixes a crash in imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
+        I could reproduce about 10% of the time.
+
+        * html/URLSearchParams.h:
+        Initialize the pointer to nullptr.
+
+2016-09-20  Alex Christensen  <achristen...@webkit.org>
+
         Reduce allocations in URLParser
         https://bugs.webkit.org/show_bug.cgi?id=162241
 

Modified: trunk/Source/WebCore/html/URLSearchParams.h (206178 => 206179)


--- trunk/Source/WebCore/html/URLSearchParams.h	2016-09-20 22:16:31 UTC (rev 206178)
+++ trunk/Source/WebCore/html/URLSearchParams.h	2016-09-20 22:19:16 UTC (rev 206179)
@@ -51,7 +51,7 @@
     explicit URLSearchParams(const Vector<std::pair<String, String>>&);
     void updateURL();
 
-    DOMURL* m_associatedURL;
+    DOMURL* m_associatedURL { nullptr };
     Vector<std::pair<String, String>> m_pairs;
 };
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to