[webkit-changes] [206325] trunk/Tools

Fri, 23 Sep 2016 13:24:00 -0700

Title: [206325] trunk/Tools
Revision
206325
Author
[email protected]
Date
2016-09-23 13:23:58 -0700 (Fri, 23 Sep 2016)

Log Message

iOS playback user action tests fail on some machines
https://bugs.webkit.org/show_bug.cgi?id=162504
rdar://problem/28013994

Reviewed by Jer Noble.

Avoid the need to have a timeout.

* TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
* TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
* TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
* TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (206324 => 206325)


--- trunk/Tools/ChangeLog	2016-09-23 20:16:43 UTC (rev 206324)
+++ trunk/Tools/ChangeLog	2016-09-23 20:23:58 UTC (rev 206325)
@@ -1,3 +1,18 @@
+2016-09-23  Alexey Proskuryakov  <[email protected]>
+
+        iOS playback user action tests fail on some machines
+        https://bugs.webkit.org/show_bug.cgi?id=162504
+        rdar://problem/28013994
+
+        Reviewed by Jer Noble.
+
+        Avoid the need to have a timeout.
+
+        * TestWebKitAPI/Tests/WebKit/ios/audio-only.html:
+        * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
+        * TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html:
+        * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html:
+
 2016-09-23  Carlos Garcia Campos  <[email protected]>
 
         REGRESSION(r204163): [GTK] API test /webkit2/WebKitSecurityManager/file-xhr is failing

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/audio-only.html (206324 => 206325)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/audio-only.html	2016-09-23 20:16:43 UTC (rev 206324)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/audio-only.html	2016-09-23 20:23:58 UTC (rev 206325)
@@ -4,13 +4,10 @@
     <script>
     function go() {
         var audio = document.getElementsByTagName('audio')[0];
-        timeout = window.setTimeout(notPlaying, 250);
-        audio.addEventListener('playing', playing);
-        audio.play();
+        audio.play().then(playing).catch(notPlaying);
     }
 
     function playing() {
-        window.clearTimeout(timeout);
         try {
             window.webkit.messageHandlers.testHandler.postMessage('playing');
         } catch(e) {
@@ -28,4 +25,4 @@
 <body _onload_="go()">
     <audio src=""
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html (206324 => 206325)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html	2016-09-23 20:16:43 UTC (rev 206324)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html	2016-09-23 20:23:58 UTC (rev 206325)
@@ -6,13 +6,10 @@
 
     function go() {
         var video = document.getElementsByTagName('video')[0];
-        timeout = window.setTimeout(notPlaying, 250);
-        video.addEventListener('playing', playing);
-        video.play();
+        video.play().then(playing).catch(notPlaying);
     }
 
     function playing() {
-        window.clearTimeout(timeout);
         try {
             window.webkit.messageHandlers.testHandler.postMessage('playing');
         } catch(e) {
@@ -30,4 +27,4 @@
 <body _onload_="go()">
     <video src="" webkit-playsinline></video>
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html (206324 => 206325)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html	2016-09-23 20:16:43 UTC (rev 206324)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/ios/video-without-audio.html	2016-09-23 20:23:58 UTC (rev 206325)
@@ -4,13 +4,10 @@
     <script>
     function go() {
         var video = document.getElementsByTagName('video')[0];
-        timeout = window.setTimeout(notPlaying, 250);
-        video.addEventListener('playing', playing);
-        video.play();
+        video.play().then(playing).catch(notPlaying);
     }
 
     function playing() {
-        window.clearTimeout(timeout);
         try {
             window.webkit.messageHandlers.testHandler.postMessage('playing');
         } catch(e) {
@@ -28,4 +25,4 @@
 <body _onload_="go()">
     <video src="" webkit-playsinline></video>
 </body>
-</html>
\ No newline at end of file
+</html>

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html (206324 => 206325)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html	2016-09-23 20:16:43 UTC (rev 206324)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html	2016-09-23 20:23:58 UTC (rev 206325)
@@ -5,13 +5,10 @@
 
     function go() {
         var video = document.getElementsByTagName('video')[0];
-        timeout = window.setTimeout(notPlaying, 250);
-        video.addEventListener('playing', playing);
-        video.play();
+        video.play().then(playing).catch(notPlaying);
     }
 
     function playing() {
-        window.clearTimeout(timeout);
         try {
             window.webkit.messageHandlers.testHandler.postMessage('playing');
         } catch(e) {

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to