Title: [206413] trunk/Source/WebKit2
Revision
206413
Author
[email protected]
Date
2016-09-26 22:50:13 -0700 (Mon, 26 Sep 2016)

Log Message

Delete some unused code from r202695
https://bugs.webkit.org/show_bug.cgi?id=162595
<rdar://problem/28343784>

Reviewed by Dan Bernstein.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]): Deleted.
(-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]): Deleted.
* UIProcess/API/Cocoa/WKWebViewInternal.h:
* UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
We didn't end up needing this mechanism.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (206412 => 206413)


--- trunk/Source/WebKit2/ChangeLog	2016-09-27 04:32:30 UTC (rev 206412)
+++ trunk/Source/WebKit2/ChangeLog	2016-09-27 05:50:13 UTC (rev 206413)
@@ -1,3 +1,20 @@
+2016-09-26  Tim Horton  <[email protected]>
+
+        Delete some unused code from r202695
+        https://bugs.webkit.org/show_bug.cgi?id=162595
+        <rdar://problem/28343784>
+
+        Reviewed by Dan Bernstein.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _initializeWithConfiguration:]):
+        (-[WKWebView _setIsBlankBeforeFirstNonEmptyLayout:]): Deleted.
+        (-[WKWebView _didFirstVisuallyNonEmptyLayoutForMainFrame]): Deleted.
+        * UIProcess/API/Cocoa/WKWebViewInternal.h:
+        * UIProcess/ios/PageClientImplIOS.mm:
+        (WebKit::PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame):
+        We didn't end up needing this mechanism.
+
 2016-09-26  Dan Bernstein  <[email protected]>
 
         -_webViewWebProcessDidBecomeUnresponsive: gets called when the Web process is stopped in the debugger

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (206412 => 206413)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-09-27 04:32:30 UTC (rev 206412)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-09-27 05:50:13 UTC (rev 206413)
@@ -163,16 +163,6 @@
 static const uint32_t firstSDKVersionWithLinkPreviewEnabledByDefault = 0xA0000;
 #endif
 
-#if USE(APPLE_INTERNAL_SDK)
-#import <WebKitAdditions/WKWebViewAdditionsBefore.mm>
-#else
-@implementation WKWebView (Additions)
-- (void)_setIsBlankBeforeFirstNonEmptyLayout:(BOOL)isBlank
-{
-}
-@end
-#endif
-
 #if PLATFORM(MAC)
 #import "WKTextFinderClient.h"
 #import "WKViewInternal.h"
@@ -493,8 +483,6 @@
     [_scrollView setInternalDelegate:self];
     [_scrollView setBouncesZoom:YES];
 
-    [self _setIsBlankBeforeFirstNonEmptyLayout:YES];
-
     [self addSubview:_scrollView.get()];
 
     static uint32_t programSDKVersion = dyld_get_program_sdk_version();
@@ -2100,11 +2088,6 @@
         enclosedInScrollableAncestorView:scrollViewCanScroll([self _scroller])];
 }
 
-- (void)_didFirstVisuallyNonEmptyLayoutForMainFrame
-{
-    [self _setIsBlankBeforeFirstNonEmptyLayout:NO];
-}
-
 - (void)_didFinishLoadForMainFrame
 {
     if (_gestureController)

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h (206412 => 206413)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h	2016-09-27 04:32:30 UTC (rev 206412)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebViewInternal.h	2016-09-27 05:50:13 UTC (rev 206413)
@@ -103,7 +103,6 @@
 - (void)_updateVisibleContentRectAfterScrollInView:(UIScrollView *)scrollView;
 - (void)_updateContentRectsWithState:(BOOL)inStableState;
 
-- (void)_didFirstVisuallyNonEmptyLayoutForMainFrame;
 - (void)_didFinishLoadForMainFrame;
 - (void)_didFailLoadForMainFrame;
 - (void)_didSameDocumentNavigationForMainFrame:(WebKit::SameDocumentNavigationType)navigationType;

Modified: trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm (206412 => 206413)


--- trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm	2016-09-27 04:32:30 UTC (rev 206412)
+++ trunk/Source/WebKit2/UIProcess/ios/PageClientImplIOS.mm	2016-09-27 05:50:13 UTC (rev 206413)
@@ -698,7 +698,6 @@
 
 void PageClientImpl::didFirstVisuallyNonEmptyLayoutForMainFrame()
 {
-    [m_webView _didFirstVisuallyNonEmptyLayoutForMainFrame];
 }
 
 void PageClientImpl::didFinishLoadForMainFrame()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to