Title: [206433] trunk/Source/WebCore
- Revision
- 206433
- Author
- mcatanz...@igalia.com
- Date
- 2016-09-27 06:40:46 -0700 (Tue, 27 Sep 2016)
Log Message
[FreeType] Add comment further justifying use of FT_LOAD_FORCE_AUTOHINT
https://bugs.webkit.org/show_bug.cgi?id=162607
Reviewed by Martin Robinson.
* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206432 => 206433)
--- trunk/Source/WebCore/ChangeLog 2016-09-27 13:20:16 UTC (rev 206432)
+++ trunk/Source/WebCore/ChangeLog 2016-09-27 13:40:46 UTC (rev 206433)
@@ -1,3 +1,13 @@
+2016-09-27 Michael Catanzaro <mcatanz...@igalia.com>
+
+ [FreeType] Add comment further justifying use of FT_LOAD_FORCE_AUTOHINT
+ https://bugs.webkit.org/show_bug.cgi?id=162607
+
+ Reviewed by Martin Robinson.
+
+ * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:
+ (WebCore::FontCustomPlatformData::FontCustomPlatformData):
+
2016-09-27 Mario Sanchez Prada <ma...@endlessm.com>
Build fails for X11+EGL due to missing gst_gl_display_x11_new_with_display()
Modified: trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp (206432 => 206433)
--- trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp 2016-09-27 13:20:16 UTC (rev 206432)
+++ trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp 2016-09-27 13:40:46 UTC (rev 206433)
@@ -49,7 +49,12 @@
// Chrome is considering switching from autohinting to native hinting in
// https://code.google.com/p/chromium/issues/detail?id=173207 but this is
// more risk than we want to assume for now. See
- // https://bugs.webkit.org/show_bug.cgi?id=140994 before changing this.
+ // https://bugs.webkit.org/show_bug.cgi?id=140994 before changing this, and
+ // also consider that (a) the fonts' native hints will all be designed to
+ // work on Windows, and might not look good at all with FreeType, whereas
+ // automatic hints will always look decent, and (b) Fontconfig is not
+ // capable of providing any per-font hinting settings for web fonts, unlike
+ // for system fonts, so it seems acceptable to treat them differently.
buffer.ref(); // This is balanced by the buffer->deref() in releaseCustomFontData.
static cairo_user_data_key_t bufferKey;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
