Title: [206480] trunk
Revision
206480
Author
achristen...@apple.com
Date
2016-09-27 18:02:00 -0700 (Tue, 27 Sep 2016)

Log Message

Correctly parse URLs with the first tab in the fragment
https://bugs.webkit.org/show_bug.cgi?id=162650

Reviewed by Saam Barati.

Source/WebCore:

Covered by a new API test.

* platform/URLParser.cpp:
(WebCore::URLParser::fragmentSyntaxViolation):

Tools:

* TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (206479 => 206480)


--- trunk/Source/WebCore/ChangeLog	2016-09-28 01:01:29 UTC (rev 206479)
+++ trunk/Source/WebCore/ChangeLog	2016-09-28 01:02:00 UTC (rev 206480)
@@ -1,3 +1,15 @@
+2016-09-27  Alex Christensen  <achristen...@webkit.org>
+
+        Correctly parse URLs with the first tab in the fragment
+        https://bugs.webkit.org/show_bug.cgi?id=162650
+
+        Reviewed by Saam Barati.
+
+        Covered by a new API test.
+
+        * platform/URLParser.cpp:
+        (WebCore::URLParser::fragmentSyntaxViolation):
+
 2016-09-27  Chris Dumez  <cdu...@apple.com>
 
         <a download> does not honor the same-origin requirement

Modified: trunk/Source/WebCore/platform/URLParser.cpp (206479 => 206480)


--- trunk/Source/WebCore/platform/URLParser.cpp	2016-09-28 01:01:29 UTC (rev 206479)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-09-28 01:02:00 UTC (rev 206480)
@@ -966,6 +966,7 @@
     if (m_didSeeSyntaxViolation)
         return;
     m_didSeeSyntaxViolation = true;
+    m_didSeeUnicodeFragmentCodePoint = true;
 
     ASSERT(m_asciiBuffer.isEmpty());
     ASSERT(m_unicodeFragmentBuffer.isEmpty());

Modified: trunk/Tools/ChangeLog (206479 => 206480)


--- trunk/Tools/ChangeLog	2016-09-28 01:01:29 UTC (rev 206479)
+++ trunk/Tools/ChangeLog	2016-09-28 01:02:00 UTC (rev 206480)
@@ -1,5 +1,15 @@
 2016-09-27  Alex Christensen  <achristen...@webkit.org>
 
+        Correctly parse URLs with the first tab in the fragment
+        https://bugs.webkit.org/show_bug.cgi?id=162650
+
+        Reviewed by Saam Barati.
+
+        * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
+        (TestWebKitAPI::TEST_F):
+
+2016-09-27  Alex Christensen  <achristen...@webkit.org>
+
         URLParser: Handle windows drive letters after two slashes in relative URLs according to spec
         https://bugs.webkit.org/show_bug.cgi?id=162646
 

Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp (206479 => 206480)


--- trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-28 01:01:29 UTC (rev 206479)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp	2016-09-28 01:02:00 UTC (rev 206480)
@@ -249,6 +249,7 @@
     checkURL("data:image/png;base64,encoded/data-with-slash", {"data", "", "", "", 0, "image/png;base64,encoded/data-with-slash", "", "", "data:image/png;base64,encoded/data-with-slash"});
     checkURL("about:~", {"about", "", "", "", 0, "~", "", "", "about:~"});
     checkURL("https://@test@test@example:800\\path@end", {"", "", "", "", 0, "", "", "", "https://@test@test@example:800\\path@end"});
+    checkURL("http://www.example.com/#a\nb\rc\td", {"http", "", "", "www.example.com", 0, "/", "", "abcd", "http://www.example.com/#abcd"});
 
     // This disagrees with the web platform test for http://:@www.example.com but agrees with Chrome and URL::parse,
     // and Firefox fails the web platform test differently. Maybe the web platform test ought to be changed.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to