Diff
Modified: branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog (206487 => 206488)
--- branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog 2016-09-28 01:38:56 UTC (rev 206487)
+++ branches/safari-602.2.14.0-branch/Source/WebCore/ChangeLog 2016-09-28 01:39:03 UTC (rev 206488)
@@ -1,5 +1,27 @@
2016-09-27 Babak Shafiei <[email protected]>
+ Merge r206415. rdar://problem/28484047
+
+ 2016-09-26 Wenson Hsieh <[email protected]>
+
+ If you play a youtube video from now playing after it finished in Safari, controls disappear
+ https://bugs.webkit.org/show_bug.cgi?id=162589
+ <rdar://problem/28484047>
+
+ Reviewed by Jer Noble.
+
+ Tweaks the main content heuristic slightly to remove the "mostly in mainframe" requirement in the case of Now
+ Playing. This was added in the case of the controls manager as an additional way to identify video elements that
+ should not show controls, since we relax audio and video constraints for showing videos in the controls manager,
+ so that a video element is prevented from showing controls on grounds of lacking audio only if it has never had
+ audio before. In the case of Now Playing, we have stricter requirements for videos, which must have audio, which
+ makes the mainframe heuristic not necessary.
+
+ * html/MediaElementSession.cpp:
+ (WebCore::MediaElementSession::canShowControlsManager):
+
+2016-09-27 Babak Shafiei <[email protected]>
+
Merge r206399. rdar://problem/28457219
2016-09-26 Wenson Hsieh <[email protected]>
Modified: branches/safari-602.2.14.0-branch/Source/WebCore/html/MediaElementSession.cpp (206487 => 206488)
--- branches/safari-602.2.14.0-branch/Source/WebCore/html/MediaElementSession.cpp 2016-09-28 01:38:56 UTC (rev 206487)
+++ branches/safari-602.2.14.0-branch/Source/WebCore/html/MediaElementSession.cpp 2016-09-28 01:39:03 UTC (rev 206488)
@@ -228,7 +228,7 @@
return true;
}
- if (!isElementRectMostlyInMainFrame(m_element)) {
+ if (purpose == PlaybackControlsPurpose::ControlsManager && !isElementRectMostlyInMainFrame(m_element)) {
LOG(Media, "MediaElementSession::canShowControlsManager - returning FALSE: Not in main frame");
return false;
}
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
