Diff
Modified: trunk/LayoutTests/ChangeLog (206491 => 206492)
--- trunk/LayoutTests/ChangeLog 2016-09-28 01:39:59 UTC (rev 206491)
+++ trunk/LayoutTests/ChangeLog 2016-09-28 01:58:45 UTC (rev 206492)
@@ -1,3 +1,18 @@
+2016-09-27 Chris Dumez <[email protected]>
+
+ [iOS] Fix several Touch-related layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=162651
+
+ Reviewed by Darin Adler.
+
+ Fix several Touch-related layout tests. The first parameter to our Touch
+ constructor must be a Window but several of our tests were passing in a
+ Document.
+
+ * platform/ios-simulator/ios/touch/construct-Touch-expected.txt:
+ * platform/ios-simulator/ios/touch/resources/construct-Touch.js:
+ * platform/ios-simulator/ios/touch/resources/construct-TouchList.js:
+
2016-09-27 Zalan Bujtas <[email protected]>
REGRESSION (r204552): Yelp carousel animation is not smooth.
Modified: trunk/LayoutTests/platform/ios-simulator/ios/touch/construct-Touch-expected.txt (206491 => 206492)
--- trunk/LayoutTests/platform/ios-simulator/ios/touch/construct-Touch-expected.txt 2016-09-28 01:39:59 UTC (rev 206491)
+++ trunk/LayoutTests/platform/ios-simulator/ios/touch/construct-Touch-expected.txt 2016-09-28 01:58:45 UTC (rev 206492)
@@ -4,12 +4,12 @@
PASS Touch.prototype.toString.call(new Touch) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document)) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document, element)) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document, element, 1)) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document, element, 1, 2)) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document, element, 1, 2, 3)) is '[object Touch]'
-PASS Touch.prototype.toString.call(new Touch(document, element, 1, 2, 3, 4, 5)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window, element)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window, element, 1)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window, element, 1, 2)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window, element, 1, 2, 3)) is '[object Touch]'
+PASS Touch.prototype.toString.call(new Touch(window, element, 1, 2, 3, 4, 5)) is '[object Touch]'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-Touch.js (206491 => 206492)
--- trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-Touch.js 2016-09-28 01:39:59 UTC (rev 206491)
+++ trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-Touch.js 2016-09-28 01:58:45 UTC (rev 206492)
@@ -5,11 +5,11 @@
var element = document.getElementById('description');
shouldBe("Touch.prototype.toString.call(new Touch)", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document))", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document, element))", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document, element, 1))", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document, element, 1, 2))", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document, element, 1, 2, 3))", "'[object Touch]'");
-shouldBe("Touch.prototype.toString.call(new Touch(document, element, 1, 2, 3, 4, 5))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window, element))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window, element, 1))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window, element, 1, 2))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window, element, 1, 2, 3))", "'[object Touch]'");
+shouldBe("Touch.prototype.toString.call(new Touch(window, element, 1, 2, 3, 4, 5))", "'[object Touch]'");
var successfullyParsed = true;
Modified: trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-TouchList.js (206491 => 206492)
--- trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-TouchList.js 2016-09-28 01:39:59 UTC (rev 206491)
+++ trunk/LayoutTests/platform/ios-simulator/ios/touch/resources/construct-TouchList.js 2016-09-28 01:58:45 UTC (rev 206492)
@@ -3,9 +3,9 @@
);
var element = document.getElementById('description');
-var touch1 = new Touch(document, element, 1, 2, 3, 4);
-var touch2 = new Touch(document, element, 2, 3, 4, 5);
-var touch3 = new Touch(document, element, 3, 4, 5, 6);
+var touch1 = new Touch(window, element, 1, 2, 3, 4);
+var touch2 = new Touch(window, element, 2, 3, 4, 5);
+var touch3 = new Touch(window, element, 3, 4, 5, 6);
shouldBe("TouchList.prototype.toString.call(new TouchList)", "'[object TouchList]'");
shouldBe("TouchList.prototype.toString.call(new TouchList(touch1))", "'[object TouchList]'");
