Title: [206513] trunk/Source/WebCore
- Revision
- 206513
- Author
- [email protected]
- Date
- 2016-09-28 05:54:50 -0700 (Wed, 28 Sep 2016)
Log Message
[GTK] Simplify platformForUAString
https://bugs.webkit.org/show_bug.cgi?id=162614
Reviewed by Carlos Garcia Campos.
Note in particular that the previous PLATFORM(MAC) check was wrong here, as that is never
true for GTK; this patch risks changing it to OS(MAC_OS_X), on the hope that advertising Mac
when running on Mac might not break anything. If it does, then we should remove it and just
always pretend to be on X11.
* platform/gtk/UserAgentGtk.cpp:
(WebCore::platformForUAString):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206512 => 206513)
--- trunk/Source/WebCore/ChangeLog 2016-09-28 12:54:12 UTC (rev 206512)
+++ trunk/Source/WebCore/ChangeLog 2016-09-28 12:54:50 UTC (rev 206513)
@@ -1,5 +1,20 @@
2016-09-28 Michael Catanzaro <[email protected]>
+ [GTK] Simplify platformForUAString
+ https://bugs.webkit.org/show_bug.cgi?id=162614
+
+ Reviewed by Carlos Garcia Campos.
+
+ Note in particular that the previous PLATFORM(MAC) check was wrong here, as that is never
+ true for GTK; this patch risks changing it to OS(MAC_OS_X), on the hope that advertising Mac
+ when running on Mac might not break anything. If it does, then we should remove it and just
+ always pretend to be on X11.
+
+ * platform/gtk/UserAgentGtk.cpp:
+ (WebCore::platformForUAString):
+
+2016-09-28 Michael Catanzaro <[email protected]>
+
[GTK] Bump fake Safari version in UA
https://bugs.webkit.org/show_bug.cgi?id=162615
Modified: trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp (206512 => 206513)
--- trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp 2016-09-28 12:54:12 UTC (rev 206512)
+++ trunk/Source/WebCore/platform/gtk/UserAgentGtk.cpp 2016-09-28 12:54:50 UTC (rev 206513)
@@ -90,16 +90,10 @@
static const char* platformForUAString()
{
-#if PLATFORM(X11)
- return "X11";
-#elif OS(WINDOWS)
- return "";
-#elif PLATFORM(MAC)
+#if OS(MAC_OS_X)
return "Macintosh";
-#elif defined(GDK_WINDOWING_DIRECTFB)
- return "DirectFB";
#else
- return "Unknown";
+ return "X11";
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
