Title: [206526] trunk/Source/WebCore
- Revision
- 206526
- Author
- [email protected]
- Date
- 2016-09-28 10:33:41 -0700 (Wed, 28 Sep 2016)
Log Message
REGRESSION(r206481): ASSERTION FAILED: isDecoderAvailable()
https://bugs.webkit.org/show_bug.cgi?id=162665
Patch by Said Abou-Hallawa <[email protected]> on 2016-09-28
Reviewed by Simon Fraser.
Remove a wrong assertion from ImageSource::destroyDecodedData(). Before
r206481, the original function BitmapImage::destroyDecodedData() did not
have this assertion. Destroying the decoded ImageFrames can happen after
releasing the ImageDecoder. And it can happen also if decoding the image
fails and BitmapImage::isNull() is true. See CachedImage::finishLoading().
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::destroyDecodedData):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206525 => 206526)
--- trunk/Source/WebCore/ChangeLog 2016-09-28 17:08:17 UTC (rev 206525)
+++ trunk/Source/WebCore/ChangeLog 2016-09-28 17:33:41 UTC (rev 206526)
@@ -1,3 +1,19 @@
+2016-09-28 Said Abou-Hallawa <[email protected]>
+
+ REGRESSION(r206481): ASSERTION FAILED: isDecoderAvailable()
+ https://bugs.webkit.org/show_bug.cgi?id=162665
+
+ Reviewed by Simon Fraser.
+
+ Remove a wrong assertion from ImageSource::destroyDecodedData(). Before
+ r206481, the original function BitmapImage::destroyDecodedData() did not
+ have this assertion. Destroying the decoded ImageFrames can happen after
+ releasing the ImageDecoder. And it can happen also if decoding the image
+ fails and BitmapImage::isNull() is true. See CachedImage::finishLoading().
+
+ * platform/graphics/ImageSource.cpp:
+ (WebCore::ImageSource::destroyDecodedData):
+
2016-09-28 Youenn Fablet <[email protected]>
WebCore::ResourceErrorBase::setType is crashing
Modified: trunk/Source/WebCore/platform/graphics/ImageSource.cpp (206525 => 206526)
--- trunk/Source/WebCore/platform/graphics/ImageSource.cpp 2016-09-28 17:08:17 UTC (rev 206525)
+++ trunk/Source/WebCore/platform/graphics/ImageSource.cpp 2016-09-28 17:33:41 UTC (rev 206526)
@@ -80,7 +80,6 @@
void ImageSource::destroyDecodedData(SharedBuffer* data, bool destroyAll, size_t count)
{
- ASSERT(isDecoderAvailable());
m_frameCache.destroyDecodedData(destroyAll, count);
clear(destroyAll, count, data);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
