Title: [206530] trunk/Source/_javascript_Core
- Revision
- 206530
- Author
- [email protected]
- Date
- 2016-09-28 12:11:49 -0700 (Wed, 28 Sep 2016)
Log Message
Store-load fences should be a lot cheaper on ARM
https://bugs.webkit.org/show_bug.cgi?id=162461
Rubber stamped by Keith Miller.
It turns out that they are already cheap enough, so this change just make us use them.
* heap/SlotVisitor.cpp:
(JSC::SlotVisitor::visitChildren):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (206529 => 206530)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-28 18:26:25 UTC (rev 206529)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-28 19:11:49 UTC (rev 206530)
@@ -1,3 +1,15 @@
+2016-09-28 Filip Pizlo <[email protected]>
+
+ Store-load fences should be a lot cheaper on ARM
+ https://bugs.webkit.org/show_bug.cgi?id=162461
+
+ Rubber stamped by Keith Miller.
+
+ It turns out that they are already cheap enough, so this change just make us use them.
+
+ * heap/SlotVisitor.cpp:
+ (JSC::SlotVisitor::visitChildren):
+
2016-09-28 Ryan Haddad <[email protected]>
Unreviewed, rolling out r206522.
Modified: trunk/Source/_javascript_Core/heap/SlotVisitor.cpp (206529 => 206530)
--- trunk/Source/_javascript_Core/heap/SlotVisitor.cpp 2016-09-28 18:26:25 UTC (rev 206529)
+++ trunk/Source/_javascript_Core/heap/SlotVisitor.cpp 2016-09-28 19:11:49 UTC (rev 206530)
@@ -300,10 +300,7 @@
cell->setCellState(blacken(cell->cellState()));
- // FIXME: Make this work on ARM also.
- // https://bugs.webkit.org/show_bug.cgi?id=162461
- if (isX86())
- WTF::storeLoadFence();
+ WTF::storeLoadFence();
switch (cell->type()) {
case StringType:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
