Title: [206563] trunk/Source/WTF
- Revision
- 206563
- Author
- [email protected]
- Date
- 2016-09-28 17:03:08 -0700 (Wed, 28 Sep 2016)
Log Message
Re-enable StringView life-cycle checking.
https://bugs.webkit.org/show_bug.cgi?id=160384
<rdar://problem/28479434>
Reviewed by Saam Barati.
* wtf/text/StringView.h:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (206562 => 206563)
--- trunk/Source/WTF/ChangeLog 2016-09-28 23:51:04 UTC (rev 206562)
+++ trunk/Source/WTF/ChangeLog 2016-09-29 00:03:08 UTC (rev 206563)
@@ -1,3 +1,13 @@
+2016-09-28 Mark Lam <[email protected]>
+
+ Re-enable StringView life-cycle checking.
+ https://bugs.webkit.org/show_bug.cgi?id=160384
+ <rdar://problem/28479434>
+
+ Reviewed by Saam Barati.
+
+ * wtf/text/StringView.h:
+
2016-09-28 Filip Pizlo <[email protected]>
The write barrier should be down with TSO
Modified: trunk/Source/WTF/wtf/text/StringView.h (206562 => 206563)
--- trunk/Source/WTF/wtf/text/StringView.h 2016-09-28 23:51:04 UTC (rev 206562)
+++ trunk/Source/WTF/wtf/text/StringView.h 2016-09-29 00:03:08 UTC (rev 206563)
@@ -36,8 +36,7 @@
#include <wtf/text/StringCommon.h>
// FIXME: Enabling the StringView lifetime checking causes the MSVC build to fail. Figure out why.
-// FIXME: Enable StringView lifetime checking once the underlying assertions have been fixed.
-#if defined(NDEBUG) || COMPILER(MSVC) || 1
+#if defined(NDEBUG) || COMPILER(MSVC)
#define CHECK_STRINGVIEW_LIFETIME 0
#else
#define CHECK_STRINGVIEW_LIFETIME 1
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
