[webkit-changes] [206618] trunk

Thu, 29 Sep 2016 15:15:39 -0700

Title: [206618] trunk
Revision
206618
Author
[email protected]
Date
2016-09-29 15:15:57 -0700 (Thu, 29 Sep 2016)

Log Message

Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
https://bugs.webkit.org/show_bug.cgi?id=130600
<rdar://problem/16391333>

Patch by Aaron Chu <[email protected]> on 2016-09-29
Reviewed by Brian Burg.

.:

Added a manual test to test the node links in the Accessibility Inspector
https://bugs.webkit.org/show_bug.cgi?id=130600

* ManualTests/accessibility/delinkified-non-navigable-links.html: Added.

Source/WebInspectorUI:

Removing link style for non-navigable nodes by first
checking nodeType of the node.

* UserInterface/Base/DOMUtilities.js:
(WebInspector.linkifyNodeReference):

Modified Paths

Added Paths

Diff

Modified: trunk/ChangeLog (206617 => 206618)


--- trunk/ChangeLog	2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/ChangeLog	2016-09-29 22:15:57 UTC (rev 206618)
@@ -1,3 +1,16 @@
+2016-09-29  Aaron Chu  <[email protected]>
+
+        Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
+        https://bugs.webkit.org/show_bug.cgi?id=130600
+        <rdar://problem/16391333>
+
+        Reviewed by Brian Burg.
+
+        Added a manual test to test the node links in the Accessibility Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=130600
+
+        * ManualTests/accessibility/delinkified-non-navigable-links.html: Added.
+
 2016-09-28  Michael Catanzaro  <[email protected]>
 
         [GTK] Remove obsolete comment from OptionsGTK.cmake

Added: trunk/ManualTests/accessibility/delinkified-non-navigable-links.html (0 => 206618)


--- trunk/ManualTests/accessibility/delinkified-non-navigable-links.html	                        (rev 0)
+++ trunk/ManualTests/accessibility/delinkified-non-navigable-links.html	2016-09-29 22:15:57 UTC (rev 206618)
@@ -0,0 +1,23 @@
+<html>
+<body>
+
+
+<p>Test for <a href="" 130600: Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them</a>.</p>
+<ol>
+<li>Open Accessibility Inspector.</li>
+<li>In DOM tree in the Web Inspector, click on the first &lt;html&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see "#document" as parent, but it should not look like a link.</li>
+<li>In DOM tree in the Web Inspector, click on a &lt;p&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see "#document" as parent, but it should not look like a link.</li>
+<li>In the Accessibility Inspector, you should be able to see a ":role(text)" under "Children", but it should not look like a link.</li>
+<li>In DOM tree in the Web Inspector, click on the &lt;iframe&gt;.</li>
+<li>In the Accessibility Inspector, you should be able to see a "#document" under "Children", and it <b>should</b> not look like a link.</li>
+
+</ol>
+
+<p>A paragraph</p>
+
+<iframe></iframe>
+
+</body>
+</html>

Modified: trunk/Source/WebInspectorUI/ChangeLog (206617 => 206618)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-09-29 22:15:57 UTC (rev 206618)
@@ -1,3 +1,17 @@
+2016-09-29  Aaron Chu  <[email protected]>
+
+        Web Inspector: AXI: linkified refs to #document and #text are not usually navigable nodes; consider delinkifying them
+        https://bugs.webkit.org/show_bug.cgi?id=130600
+        <rdar://problem/16391333>
+
+        Reviewed by Brian Burg.
+
+        Removing link style for non-navigable nodes by first
+        checking nodeType of the node.
+
+        * UserInterface/Base/DOMUtilities.js:
+        (WebInspector.linkifyNodeReference):
+
 2016-09-27  Matt Baker  <[email protected]>
 
         Web Inspector: Refreshing while in Timelines-tab causes negative timestamps in Network-tab

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js (206617 => 206618)


--- trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js	2016-09-29 22:02:04 UTC (rev 206617)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js	2016-09-29 22:15:57 UTC (rev 206618)
@@ -66,8 +66,12 @@
     let link = document.createElement("span");
     link.append(displayName);
     link.setAttribute("role", "link");
-    link.className = "node-link";
+    
     link.title = displayName;
+    
+    let nodeType = node.nodeType();
+    if ((nodeType !== Node.DOCUMENT_NODE || node.parentNode) && nodeType !== Node.TEXT_NODE)
+        link.className = "node-link";
 
     link.addEventListener("click", WebInspector.domTreeManager.inspectElement.bind(WebInspector.domTreeManager, node.id));
     link.addEventListener("mouseover", WebInspector.domTreeManager.highlightDOMNode.bind(WebInspector.domTreeManager, node.id, "all"));

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to