Title: [206634] trunk
- Revision
- 206634
- Author
- [email protected]
- Date
- 2016-09-30 07:20:25 -0700 (Fri, 30 Sep 2016)
Log Message
Add support for ImageData.data attribute
https://bugs.webkit.org/show_bug.cgi?id=162767
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
* web-platform-tests/html/dom/interfaces-expected.txt:
Source/WebCore:
Add support for ImageData.data attribute:
- https://html.spec.whatwg.org/#imagedata
Firefox already supports it.
No new tests, updated existing tests.
* html/ImageData.idl:
LayoutTests:
Add layout test coverage.
* fast/canvas/canvas-imageData-expected.txt:
* fast/canvas/script-tests/canvas-imageData.js:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (206633 => 206634)
--- trunk/LayoutTests/ChangeLog 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/LayoutTests/ChangeLog 2016-09-30 14:20:25 UTC (rev 206634)
@@ -1,3 +1,15 @@
+2016-09-30 Chris Dumez <[email protected]>
+
+ Add support for ImageData.data attribute
+ https://bugs.webkit.org/show_bug.cgi?id=162767
+
+ Reviewed by Sam Weinig.
+
+ Add layout test coverage.
+
+ * fast/canvas/canvas-imageData-expected.txt:
+ * fast/canvas/script-tests/canvas-imageData.js:
+
2016-09-30 Youenn Fablet <[email protected]>
DumpRenderTree crashed in com.apple.WebCore: WTF::Optional<WebCore::FetchBodyOwner::BlobLoader>::operator bool const + 12
Modified: trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt (206633 => 206634)
--- trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/LayoutTests/fast/canvas/canvas-imageData-expected.txt 2016-09-30 14:20:25 UTC (rev 206634)
@@ -40,6 +40,7 @@
PASS imageData.data[1] is 100
PASS testTransparentBlack(imageData2.data) is true
+PASS imageData2.data is data
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/canvas/script-tests/canvas-imageData.js (206633 => 206634)
--- trunk/LayoutTests/fast/canvas/script-tests/canvas-imageData.js 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/LayoutTests/fast/canvas/script-tests/canvas-imageData.js 2016-09-30 14:20:25 UTC (rev 206634)
@@ -62,3 +62,8 @@
var imageData2 = new ImageData(100,100);
shouldBeTrue('testTransparentBlack(imageData2.data)');
+
+var data = "" Uint8ClampedArray(400);
+var imageData2 = new ImageData(data, 20, 5);
+shouldBe("imageData2.data", "data");
+
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206633 => 206634)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2016-09-30 14:20:25 UTC (rev 206634)
@@ -1,3 +1,14 @@
+2016-09-30 Chris Dumez <[email protected]>
+
+ Add support for ImageData.data attribute
+ https://bugs.webkit.org/show_bug.cgi?id=162767
+
+ Reviewed by Sam Weinig.
+
+ Rebaseline W3C test now that one more check is passing.
+
+ * web-platform-tests/html/dom/interfaces-expected.txt:
+
2016-09-30 Youenn Fablet <[email protected]>
[Fetch API] Add support for URLSearchParams body
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt (206633 => 206634)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt 2016-09-30 14:20:25 UTC (rev 206634)
@@ -4882,7 +4882,7 @@
PASS ImageData interface: existence and properties of interface prototype object's "constructor" property
PASS ImageData interface: attribute width
PASS ImageData interface: attribute height
-FAIL ImageData interface: attribute data assert_true: The prototype object must have a property "data" expected true got false
+PASS ImageData interface: attribute data
PASS Path2D interface: existence and properties of interface object
PASS Path2D interface object length
PASS Path2D interface object name
Modified: trunk/Source/WebCore/ChangeLog (206633 => 206634)
--- trunk/Source/WebCore/ChangeLog 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/Source/WebCore/ChangeLog 2016-09-30 14:20:25 UTC (rev 206634)
@@ -1,3 +1,19 @@
+2016-09-30 Chris Dumez <[email protected]>
+
+ Add support for ImageData.data attribute
+ https://bugs.webkit.org/show_bug.cgi?id=162767
+
+ Reviewed by Sam Weinig.
+
+ Add support for ImageData.data attribute:
+ - https://html.spec.whatwg.org/#imagedata
+
+ Firefox already supports it.
+
+ No new tests, updated existing tests.
+
+ * html/ImageData.idl:
+
2016-09-30 Youenn Fablet <[email protected]>
DumpRenderTree crashed in com.apple.WebCore: WTF::Optional<WebCore::FetchBodyOwner::BlobLoader>::operator bool const + 12
Modified: trunk/Source/WebCore/html/ImageData.idl (206633 => 206634)
--- trunk/Source/WebCore/html/ImageData.idl 2016-09-30 08:27:02 UTC (rev 206633)
+++ trunk/Source/WebCore/html/ImageData.idl 2016-09-30 14:20:25 UTC (rev 206634)
@@ -36,4 +36,5 @@
] interface ImageData {
readonly attribute long width;
readonly attribute long height;
+ readonly attribute Uint8ClampedArray data;
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
