Title: [206658] trunk/Source/_javascript_Core
- Revision
- 206658
- Author
- [email protected]
- Date
- 2016-09-30 12:47:54 -0700 (Fri, 30 Sep 2016)
Log Message
Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied().
https://bugs.webkit.org/show_bug.cgi?id=162797
Reviewed by Geoffrey Garen.
This is because the RELEASE_ASSERT() that follows immediately after will also
dump the stack back trace. Hence, the first dump will be redundant.
Also removed an extra space in the dataLog output.
* runtime/VM.cpp:
(JSC::VM::verifyExceptionCheckNeedIsSatisfied):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (206657 => 206658)
--- trunk/Source/_javascript_Core/ChangeLog 2016-09-30 19:45:58 UTC (rev 206657)
+++ trunk/Source/_javascript_Core/ChangeLog 2016-09-30 19:47:54 UTC (rev 206658)
@@ -1,3 +1,18 @@
+2016-09-30 Mark Lam <[email protected]>
+
+ Remove the dumping of the stack back trace in VM::verifyExceptionCheckNeedIsSatisfied().
+ https://bugs.webkit.org/show_bug.cgi?id=162797
+
+ Reviewed by Geoffrey Garen.
+
+ This is because the RELEASE_ASSERT() that follows immediately after will also
+ dump the stack back trace. Hence, the first dump will be redundant.
+
+ Also removed an extra space in the dataLog output.
+
+ * runtime/VM.cpp:
+ (JSC::VM::verifyExceptionCheckNeedIsSatisfied):
+
2016-09-30 Joseph Pecoraro <[email protected]>
Web Inspector: Stepping through `a(); b(); c();` it is unclear where we are and what is about to execute
Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (206657 => 206658)
--- trunk/Source/_javascript_Core/runtime/VM.cpp 2016-09-30 19:45:58 UTC (rev 206657)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp 2016-09-30 19:47:54 UTC (rev 206658)
@@ -906,11 +906,10 @@
dataLog(
"ERROR: Unchecked JS exception:\n"
" This scope can throw a JS exception: ", throwLocation, "\n"
- " (ExceptionScope::m_recursionDepth was ", throwDepth, ")\n"
+ " (ExceptionScope::m_recursionDepth was ", throwDepth, ")\n"
" But the exception was unchecked as of this scope: ", location, "\n"
- " (ExceptionScope::m_recursionDepth was ", recursionDepth, ")\n"
+ " (ExceptionScope::m_recursionDepth was ", recursionDepth, ")\n"
"\n");
- WTFReportBacktrace();
RELEASE_ASSERT(!m_needExceptionCheck);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
