Title: [206722] trunk/Source/WebInspectorUI
Revision
206722
Author
[email protected]
Date
2016-10-02 13:59:06 -0700 (Sun, 02 Oct 2016)

Log Message

Web Inspector: Exception thrown when hovering network waterfall graphs during reload
https://bugs.webkit.org/show_bug.cgi?id=162850
<rdar://problem/28579653>

Reviewed by Brian Burg.

* UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
Check that the node's data grid reference is valid before use.
(WebInspector.ResourceTimelineDataGridNode):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (206721 => 206722)


--- trunk/Source/WebInspectorUI/ChangeLog	2016-10-02 19:22:18 UTC (rev 206721)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-10-02 20:59:06 UTC (rev 206722)
@@ -1,3 +1,16 @@
+2016-10-02  Matt Baker  <[email protected]>
+
+        Web Inspector: Exception thrown when hovering network waterfall graphs during reload
+        https://bugs.webkit.org/show_bug.cgi?id=162850
+        <rdar://problem/28579653>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ResourceTimelineDataGridNode.js:
+        (WebInspector.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar):
+        Check that the node's data grid reference is valid before use.
+        (WebInspector.ResourceTimelineDataGridNode):
+
 2016-10-01  Joseph Pecoraro  <[email protected]>
 
         Web Inspector: Selection does not show up over execution highlight ranges

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js (206721 => 206722)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js	2016-10-02 19:22:18 UTC (rev 206721)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js	2016-10-02 20:59:06 UTC (rev 206722)
@@ -374,6 +374,8 @@
         };
 
         recordBar.element.addEventListener("mouseleave", () => {
+            if (!this.dataGrid)
+                return;
             this.dataGrid._dismissPopoverTimeout = setTimeout(() => this.dataGrid._popover.dismiss(), WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout);
         }, {once: true});
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to