Diff
Modified: trunk/LayoutTests/ChangeLog (206724 => 206725)
--- trunk/LayoutTests/ChangeLog 2016-10-02 21:33:28 UTC (rev 206724)
+++ trunk/LayoutTests/ChangeLog 2016-10-02 21:49:44 UTC (rev 206725)
@@ -1,5 +1,17 @@
2016-10-02 Chris Dumez <[email protected]>
+ Add support for KeyboardEvent.getModifierState() operation
+ https://bugs.webkit.org/show_bug.cgi?id=162855
+
+ Reviewed by Darin Adler.
+
+ Add layout test coverage.
+
+ * fast/events/constructors/keyboard-event-getModifierState-expected.txt: Added.
+ * fast/events/constructors/keyboard-event-getModifierState.html: Added.
+
+2016-10-02 Chris Dumez <[email protected]>
+
Add support for KeyboardEvent.repeat attribute
https://bugs.webkit.org/show_bug.cgi?id=162854
Added: trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt (0 => 206725)
--- trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState-expected.txt 2016-10-02 21:49:44 UTC (rev 206725)
@@ -0,0 +1,33 @@
+This tests KeyboardEvent.getModifierState().
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS event.getModifierState('Control') is false
+PASS event.getModifierState('Alt') is false
+PASS event.getModifierState('Shift') is false
+PASS event.getModifierState('Meta') is false
+PASS event.getModifierState('Control') is true
+PASS event.getModifierState('Alt') is false
+PASS event.getModifierState('Shift') is false
+PASS event.getModifierState('Meta') is false
+PASS event.getModifierState('Control') is false
+PASS event.getModifierState('Alt') is true
+PASS event.getModifierState('Shift') is false
+PASS event.getModifierState('Meta') is false
+PASS event.getModifierState('Control') is false
+PASS event.getModifierState('Alt') is false
+PASS event.getModifierState('Shift') is true
+PASS event.getModifierState('Meta') is false
+PASS event.getModifierState('Control') is false
+PASS event.getModifierState('Alt') is false
+PASS event.getModifierState('Shift') is false
+PASS event.getModifierState('Meta') is true
+PASS event.getModifierState('Control') is true
+PASS event.getModifierState('Alt') is true
+PASS event.getModifierState('Shift') is true
+PASS event.getModifierState('Meta') is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html (0 => 206725)
--- trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html (rev 0)
+++ trunk/LayoutTests/fast/events/constructors/keyboard-event-getModifierState.html 2016-10-02 21:49:44 UTC (rev 206725)
@@ -0,0 +1,49 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script src=""
+</head>
+<body>
+<script>
+
+description("This tests KeyboardEvent.getModifierState().");
+
+var event = new KeyboardEvent('keydown', { });
+shouldBeFalse("event.getModifierState('Control')");
+shouldBeFalse("event.getModifierState('Alt')");
+shouldBeFalse("event.getModifierState('Shift')");
+shouldBeFalse("event.getModifierState('Meta')");
+
+var event = new KeyboardEvent('keydown', { ctrlKey: true });
+shouldBeTrue("event.getModifierState('Control')");
+shouldBeFalse("event.getModifierState('Alt')");
+shouldBeFalse("event.getModifierState('Shift')");
+shouldBeFalse("event.getModifierState('Meta')");
+
+var event = new KeyboardEvent('keydown', { altKey: true });
+shouldBeFalse("event.getModifierState('Control')");
+shouldBeTrue("event.getModifierState('Alt')");
+shouldBeFalse("event.getModifierState('Shift')");
+shouldBeFalse("event.getModifierState('Meta')");
+
+var event = new KeyboardEvent('keydown', { shiftKey: true });
+shouldBeFalse("event.getModifierState('Control')");
+shouldBeFalse("event.getModifierState('Alt')");
+shouldBeTrue("event.getModifierState('Shift')");
+shouldBeFalse("event.getModifierState('Meta')");
+
+var event = new KeyboardEvent('keydown', { metaKey: true });
+shouldBeFalse("event.getModifierState('Control')");
+shouldBeFalse("event.getModifierState('Alt')");
+shouldBeFalse("event.getModifierState('Shift')");
+shouldBeTrue("event.getModifierState('Meta')");
+
+var event = new KeyboardEvent('keydown', { ctrlKey: true, altKey: true, shiftKey: true, metaKey: true });
+shouldBeTrue("event.getModifierState('Control')");
+shouldBeTrue("event.getModifierState('Alt')");
+shouldBeTrue("event.getModifierState('Shift')");
+shouldBeTrue("event.getModifierState('Meta')");
+</script>
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (206724 => 206725)
--- trunk/Source/WebCore/ChangeLog 2016-10-02 21:33:28 UTC (rev 206724)
+++ trunk/Source/WebCore/ChangeLog 2016-10-02 21:49:44 UTC (rev 206725)
@@ -1,5 +1,21 @@
2016-10-02 Chris Dumez <[email protected]>
+ Add support for KeyboardEvent.getModifierState() operation
+ https://bugs.webkit.org/show_bug.cgi?id=162855
+
+ Reviewed by Darin Adler.
+
+ Add support for KeyboardEvent.getModifierState() operation:
+ - https://w3c.github.io/uievents/#dom-keyboardevent-getmodifierstate
+
+ Test: fast/events/constructors/keyboard-event-getModifierState.html
+
+ * dom/KeyboardEvent.cpp:
+ (WebCore::KeyboardEvent::getModifierState):
+ * dom/KeyboardEvent.idl:
+
+2016-10-02 Chris Dumez <[email protected]>
+
Add support for KeyboardEvent.repeat attribute
https://bugs.webkit.org/show_bug.cgi?id=162854
Modified: trunk/Source/WebCore/dom/KeyboardEvent.cpp (206724 => 206725)
--- trunk/Source/WebCore/dom/KeyboardEvent.cpp 2016-10-02 21:33:28 UTC (rev 206724)
+++ trunk/Source/WebCore/dom/KeyboardEvent.cpp 2016-10-02 21:49:44 UTC (rev 206725)
@@ -169,6 +169,9 @@
return altKey();
if (keyIdentifier == "Meta")
return metaKey();
+ if (keyIdentifier == "AltGraph")
+ return altGraphKey();
+ // FIXME: We should support CapsLock, Fn, FnLock, Hyper, NumLock, Super, ScrollLock, Symbol, SymbolLock.
return false;
}
Modified: trunk/Source/WebCore/dom/KeyboardEvent.idl (206724 => 206725)
--- trunk/Source/WebCore/dom/KeyboardEvent.idl 2016-10-02 21:33:28 UTC (rev 206724)
+++ trunk/Source/WebCore/dom/KeyboardEvent.idl 2016-10-02 21:49:44 UTC (rev 206725)
@@ -39,6 +39,8 @@
[InitializedByEventConstructor] readonly attribute boolean repeat;
+ boolean getModifierState(DOMString keyArg);
+
// FIXME: this does not match the version in the DOM spec.
// FIXME: Using "undefined" as default parameter value is wrong.
void initKeyboardEvent(optional DOMString type = "undefined", optional boolean canBubble = false, optional boolean cancelable = false,
