Title: [206733] trunk
Revision
206733
Author
[email protected]
Date
2016-10-03 09:23:24 -0700 (Mon, 03 Oct 2016)

Log Message

td.scope should only return known values
https://bugs.webkit.org/show_bug.cgi?id=162755

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

* web-platform-tests/html/dom/reflection-tabular-expected.txt:

Source/WebCore:

td.scope should only return known values:
- https://html.spec.whatwg.org/#dom-th-scope

Firefox conforms to the specification.

No new tests, rebaselined existing test.

* html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::scope):

LayoutTests:

Update existing test to reflect behavior change.

* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/element-attribute-js-null.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (206732 => 206733)


--- trunk/LayoutTests/ChangeLog	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/LayoutTests/ChangeLog	2016-10-03 16:23:24 UTC (rev 206733)
@@ -1,3 +1,15 @@
+2016-10-03  Chris Dumez  <[email protected]>
+
+        td.scope should only return known values
+        https://bugs.webkit.org/show_bug.cgi?id=162755
+
+        Reviewed by Sam Weinig.
+
+        Update existing test to reflect behavior change.
+
+        * fast/dom/element-attribute-js-null-expected.txt:
+        * fast/dom/element-attribute-js-null.html:
+
 2016-10-02  Chris Dumez  <[email protected]>
 
         Add support for KeyboardEvent.getModifierState() operation

Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt (206732 => 206733)


--- trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt	2016-10-03 16:23:24 UTC (rev 206733)
@@ -192,7 +192,7 @@
 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.chOff]
 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.headers]
 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.height]
-TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.scope]
+TEST SUCCEEDED: The value was the empty string. [tested HTMLTableCellElement.scope]
 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.vAlign]
 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLTableCellElement.width]
 

Modified: trunk/LayoutTests/fast/dom/element-attribute-js-null.html (206732 => 206733)


--- trunk/LayoutTests/fast/dom/element-attribute-js-null.html	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/LayoutTests/fast/dom/element-attribute-js-null.html	2016-10-03 16:23:24 UTC (rev 206733)
@@ -487,7 +487,7 @@
                         {name: 'chOff', expectedNull: 'null'},
                         {name: 'headers', expectedNull: 'null'},
                         {name: 'height', expectedNull: 'null'},
-                        {name: 'scope', expectedNull: 'null'},
+                        {name: 'scope', expectedNull: ''},
                         {name: 'vAlign', expectedNull: 'null'},
                         {name: 'width', expectedNull: 'null'}
                     ]

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (206732 => 206733)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-10-03 16:23:24 UTC (rev 206733)
@@ -1,3 +1,14 @@
+2016-10-03  Chris Dumez  <[email protected]>
+
+        td.scope should only return known values
+        https://bugs.webkit.org/show_bug.cgi?id=162755
+
+        Reviewed by Sam Weinig.
+
+        Rebaseline W3C test now that more checks are passing.
+
+        * web-platform-tests/html/dom/reflection-tabular-expected.txt:
+
 2016-10-02  Commit Queue  <[email protected]>
 
         Unreviewed, rolling out r206716.

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt (206732 => 206733)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-tabular-expected.txt	2016-10-03 16:23:24 UTC (rev 206733)
@@ -8674,177 +8674,177 @@
 PASS td.scope: setAttribute() to "" followed by getAttribute() 
 PASS td.scope: setAttribute() to "" followed by IDL get 
 PASS td.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by getAttribute() 
-FAIL td.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by IDL get assert_equals: expected "" but got " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo "
+PASS td.scope: setAttribute() to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by IDL get 
 PASS td.scope: setAttribute() to undefined followed by getAttribute() 
-FAIL td.scope: setAttribute() to undefined followed by IDL get assert_equals: expected "" but got "undefined"
+PASS td.scope: setAttribute() to undefined followed by IDL get 
 PASS td.scope: setAttribute() to 7 followed by getAttribute() 
-FAIL td.scope: setAttribute() to 7 followed by IDL get assert_equals: expected "" but got "7"
+PASS td.scope: setAttribute() to 7 followed by IDL get 
 PASS td.scope: setAttribute() to 1.5 followed by getAttribute() 
-FAIL td.scope: setAttribute() to 1.5 followed by IDL get assert_equals: expected "" but got "1.5"
+PASS td.scope: setAttribute() to 1.5 followed by IDL get 
 PASS td.scope: setAttribute() to true followed by getAttribute() 
-FAIL td.scope: setAttribute() to true followed by IDL get assert_equals: expected "" but got "true"
+PASS td.scope: setAttribute() to true followed by IDL get 
 PASS td.scope: setAttribute() to false followed by getAttribute() 
-FAIL td.scope: setAttribute() to false followed by IDL get assert_equals: expected "" but got "false"
+PASS td.scope: setAttribute() to false followed by IDL get 
 PASS td.scope: setAttribute() to object "[object Object]" followed by getAttribute() 
-FAIL td.scope: setAttribute() to object "[object Object]" followed by IDL get assert_equals: expected "" but got "[object Object]"
+PASS td.scope: setAttribute() to object "[object Object]" followed by IDL get 
 PASS td.scope: setAttribute() to NaN followed by getAttribute() 
-FAIL td.scope: setAttribute() to NaN followed by IDL get assert_equals: expected "" but got "NaN"
+PASS td.scope: setAttribute() to NaN followed by IDL get 
 PASS td.scope: setAttribute() to Infinity followed by getAttribute() 
-FAIL td.scope: setAttribute() to Infinity followed by IDL get assert_equals: expected "" but got "Infinity"
+PASS td.scope: setAttribute() to Infinity followed by IDL get 
 PASS td.scope: setAttribute() to -Infinity followed by getAttribute() 
-FAIL td.scope: setAttribute() to -Infinity followed by IDL get assert_equals: expected "" but got "-Infinity"
+PASS td.scope: setAttribute() to -Infinity followed by IDL get 
 PASS td.scope: setAttribute() to "\0" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "\0" followed by IDL get assert_equals: expected "" but got "\0"
+PASS td.scope: setAttribute() to "\0" followed by IDL get 
 PASS td.scope: setAttribute() to null followed by getAttribute() 
-FAIL td.scope: setAttribute() to null followed by IDL get assert_equals: expected "" but got "null"
+PASS td.scope: setAttribute() to null followed by IDL get 
 PASS td.scope: setAttribute() to object "test-toString" followed by getAttribute() 
-FAIL td.scope: setAttribute() to object "test-toString" followed by IDL get assert_equals: expected "" but got "test-toString"
+PASS td.scope: setAttribute() to object "test-toString" followed by IDL get 
 PASS td.scope: setAttribute() to object "test-valueOf" followed by getAttribute() 
-FAIL td.scope: setAttribute() to object "test-valueOf" followed by IDL get assert_equals: expected "" but got "test-valueOf"
+PASS td.scope: setAttribute() to object "test-valueOf" followed by IDL get 
 PASS td.scope: setAttribute() to "row" followed by getAttribute() 
 PASS td.scope: setAttribute() to "row" followed by IDL get 
 PASS td.scope: setAttribute() to "xrow" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "xrow" followed by IDL get assert_equals: expected "" but got "xrow"
+PASS td.scope: setAttribute() to "xrow" followed by IDL get 
 PASS td.scope: setAttribute() to "row\0" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "row\0" followed by IDL get assert_equals: expected "" but got "row\0"
+PASS td.scope: setAttribute() to "row\0" followed by IDL get 
 PASS td.scope: setAttribute() to "ow" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "ow" followed by IDL get assert_equals: expected "" but got "ow"
+PASS td.scope: setAttribute() to "ow" followed by IDL get 
 PASS td.scope: setAttribute() to "ROW" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "ROW" followed by IDL get assert_equals: expected "row" but got "ROW"
+PASS td.scope: setAttribute() to "ROW" followed by IDL get 
 PASS td.scope: setAttribute() to "col" followed by getAttribute() 
 PASS td.scope: setAttribute() to "col" followed by IDL get 
 PASS td.scope: setAttribute() to "xcol" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "xcol" followed by IDL get assert_equals: expected "" but got "xcol"
+PASS td.scope: setAttribute() to "xcol" followed by IDL get 
 PASS td.scope: setAttribute() to "col\0" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "col\0" followed by IDL get assert_equals: expected "" but got "col\0"
+PASS td.scope: setAttribute() to "col\0" followed by IDL get 
 PASS td.scope: setAttribute() to "ol" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "ol" followed by IDL get assert_equals: expected "" but got "ol"
+PASS td.scope: setAttribute() to "ol" followed by IDL get 
 PASS td.scope: setAttribute() to "COL" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "COL" followed by IDL get assert_equals: expected "col" but got "COL"
+PASS td.scope: setAttribute() to "COL" followed by IDL get 
 PASS td.scope: setAttribute() to "rowgroup" followed by getAttribute() 
 PASS td.scope: setAttribute() to "rowgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "xrowgroup" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "xrowgroup" followed by IDL get assert_equals: expected "" but got "xrowgroup"
+PASS td.scope: setAttribute() to "xrowgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "rowgroup\0" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "rowgroup\0" followed by IDL get assert_equals: expected "" but got "rowgroup\0"
+PASS td.scope: setAttribute() to "rowgroup\0" followed by IDL get 
 PASS td.scope: setAttribute() to "owgroup" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "owgroup" followed by IDL get assert_equals: expected "" but got "owgroup"
+PASS td.scope: setAttribute() to "owgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "ROWGROUP" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "ROWGROUP" followed by IDL get assert_equals: expected "rowgroup" but got "ROWGROUP"
+PASS td.scope: setAttribute() to "ROWGROUP" followed by IDL get 
 PASS td.scope: setAttribute() to "colgroup" followed by getAttribute() 
 PASS td.scope: setAttribute() to "colgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "xcolgroup" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "xcolgroup" followed by IDL get assert_equals: expected "" but got "xcolgroup"
+PASS td.scope: setAttribute() to "xcolgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "colgroup\0" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "colgroup\0" followed by IDL get assert_equals: expected "" but got "colgroup\0"
+PASS td.scope: setAttribute() to "colgroup\0" followed by IDL get 
 PASS td.scope: setAttribute() to "olgroup" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "olgroup" followed by IDL get assert_equals: expected "" but got "olgroup"
+PASS td.scope: setAttribute() to "olgroup" followed by IDL get 
 PASS td.scope: setAttribute() to "COLGROUP" followed by getAttribute() 
-FAIL td.scope: setAttribute() to "COLGROUP" followed by IDL get assert_equals: expected "colgroup" but got "COLGROUP"
+PASS td.scope: setAttribute() to "COLGROUP" followed by IDL get 
 PASS td.scope: IDL set to "" should not throw 
 PASS td.scope: IDL set to "" followed by getAttribute() 
 PASS td.scope: IDL set to "" followed by IDL get 
 PASS td.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " should not throw 
 PASS td.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by getAttribute() 
-FAIL td.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by IDL get assert_equals: expected "" but got " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo "
+PASS td.scope: IDL set to " \0\x01\x02\x03\x04\x05\x06\x07 \b\t\n\v\f\r\x0e\x0f \x10\x11\x12\x13\x14\x15\x16\x17 \x18\x19\x1a\x1b\x1c\x1d\x1e\x1f  foo " followed by IDL get 
 PASS td.scope: IDL set to undefined should not throw 
 PASS td.scope: IDL set to undefined followed by getAttribute() 
-FAIL td.scope: IDL set to undefined followed by IDL get assert_equals: expected "" but got "undefined"
+PASS td.scope: IDL set to undefined followed by IDL get 
 PASS td.scope: IDL set to 7 should not throw 
 PASS td.scope: IDL set to 7 followed by getAttribute() 
-FAIL td.scope: IDL set to 7 followed by IDL get assert_equals: expected "" but got "7"
+PASS td.scope: IDL set to 7 followed by IDL get 
 PASS td.scope: IDL set to 1.5 should not throw 
 PASS td.scope: IDL set to 1.5 followed by getAttribute() 
-FAIL td.scope: IDL set to 1.5 followed by IDL get assert_equals: expected "" but got "1.5"
+PASS td.scope: IDL set to 1.5 followed by IDL get 
 PASS td.scope: IDL set to true should not throw 
 PASS td.scope: IDL set to true followed by getAttribute() 
-FAIL td.scope: IDL set to true followed by IDL get assert_equals: expected "" but got "true"
+PASS td.scope: IDL set to true followed by IDL get 
 PASS td.scope: IDL set to false should not throw 
 PASS td.scope: IDL set to false followed by getAttribute() 
-FAIL td.scope: IDL set to false followed by IDL get assert_equals: expected "" but got "false"
+PASS td.scope: IDL set to false followed by IDL get 
 PASS td.scope: IDL set to object "[object Object]" should not throw 
 PASS td.scope: IDL set to object "[object Object]" followed by getAttribute() 
-FAIL td.scope: IDL set to object "[object Object]" followed by IDL get assert_equals: expected "" but got "[object Object]"
+PASS td.scope: IDL set to object "[object Object]" followed by IDL get 
 PASS td.scope: IDL set to NaN should not throw 
 PASS td.scope: IDL set to NaN followed by getAttribute() 
-FAIL td.scope: IDL set to NaN followed by IDL get assert_equals: expected "" but got "NaN"
+PASS td.scope: IDL set to NaN followed by IDL get 
 PASS td.scope: IDL set to Infinity should not throw 
 PASS td.scope: IDL set to Infinity followed by getAttribute() 
-FAIL td.scope: IDL set to Infinity followed by IDL get assert_equals: expected "" but got "Infinity"
+PASS td.scope: IDL set to Infinity followed by IDL get 
 PASS td.scope: IDL set to -Infinity should not throw 
 PASS td.scope: IDL set to -Infinity followed by getAttribute() 
-FAIL td.scope: IDL set to -Infinity followed by IDL get assert_equals: expected "" but got "-Infinity"
+PASS td.scope: IDL set to -Infinity followed by IDL get 
 PASS td.scope: IDL set to "\0" should not throw 
 PASS td.scope: IDL set to "\0" followed by getAttribute() 
-FAIL td.scope: IDL set to "\0" followed by IDL get assert_equals: expected "" but got "\0"
+PASS td.scope: IDL set to "\0" followed by IDL get 
 PASS td.scope: IDL set to null should not throw 
-FAIL td.scope: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
+PASS td.scope: IDL set to null followed by IDL get 
 PASS td.scope: IDL set to object "test-toString" should not throw 
 PASS td.scope: IDL set to object "test-toString" followed by getAttribute() 
-FAIL td.scope: IDL set to object "test-toString" followed by IDL get assert_equals: expected "" but got "test-toString"
+PASS td.scope: IDL set to object "test-toString" followed by IDL get 
 PASS td.scope: IDL set to object "test-valueOf" should not throw 
 PASS td.scope: IDL set to object "test-valueOf" followed by getAttribute() 
-FAIL td.scope: IDL set to object "test-valueOf" followed by IDL get assert_equals: expected "" but got "test-valueOf"
+PASS td.scope: IDL set to object "test-valueOf" followed by IDL get 
 PASS td.scope: IDL set to "row" should not throw 
 PASS td.scope: IDL set to "row" followed by getAttribute() 
 PASS td.scope: IDL set to "row" followed by IDL get 
 PASS td.scope: IDL set to "xrow" should not throw 
 PASS td.scope: IDL set to "xrow" followed by getAttribute() 
-FAIL td.scope: IDL set to "xrow" followed by IDL get assert_equals: expected "" but got "xrow"
+PASS td.scope: IDL set to "xrow" followed by IDL get 
 PASS td.scope: IDL set to "row\0" should not throw 
 PASS td.scope: IDL set to "row\0" followed by getAttribute() 
-FAIL td.scope: IDL set to "row\0" followed by IDL get assert_equals: expected "" but got "row\0"
+PASS td.scope: IDL set to "row\0" followed by IDL get 
 PASS td.scope: IDL set to "ow" should not throw 
 PASS td.scope: IDL set to "ow" followed by getAttribute() 
-FAIL td.scope: IDL set to "ow" followed by IDL get assert_equals: expected "" but got "ow"
+PASS td.scope: IDL set to "ow" followed by IDL get 
 PASS td.scope: IDL set to "ROW" should not throw 
 PASS td.scope: IDL set to "ROW" followed by getAttribute() 
-FAIL td.scope: IDL set to "ROW" followed by IDL get assert_equals: expected "row" but got "ROW"
+PASS td.scope: IDL set to "ROW" followed by IDL get 
 PASS td.scope: IDL set to "col" should not throw 
 PASS td.scope: IDL set to "col" followed by getAttribute() 
 PASS td.scope: IDL set to "col" followed by IDL get 
 PASS td.scope: IDL set to "xcol" should not throw 
 PASS td.scope: IDL set to "xcol" followed by getAttribute() 
-FAIL td.scope: IDL set to "xcol" followed by IDL get assert_equals: expected "" but got "xcol"
+PASS td.scope: IDL set to "xcol" followed by IDL get 
 PASS td.scope: IDL set to "col\0" should not throw 
 PASS td.scope: IDL set to "col\0" followed by getAttribute() 
-FAIL td.scope: IDL set to "col\0" followed by IDL get assert_equals: expected "" but got "col\0"
+PASS td.scope: IDL set to "col\0" followed by IDL get 
 PASS td.scope: IDL set to "ol" should not throw 
 PASS td.scope: IDL set to "ol" followed by getAttribute() 
-FAIL td.scope: IDL set to "ol" followed by IDL get assert_equals: expected "" but got "ol"
+PASS td.scope: IDL set to "ol" followed by IDL get 
 PASS td.scope: IDL set to "COL" should not throw 
 PASS td.scope: IDL set to "COL" followed by getAttribute() 
-FAIL td.scope: IDL set to "COL" followed by IDL get assert_equals: expected "col" but got "COL"
+PASS td.scope: IDL set to "COL" followed by IDL get 
 PASS td.scope: IDL set to "rowgroup" should not throw 
 PASS td.scope: IDL set to "rowgroup" followed by getAttribute() 
 PASS td.scope: IDL set to "rowgroup" followed by IDL get 
 PASS td.scope: IDL set to "xrowgroup" should not throw 
 PASS td.scope: IDL set to "xrowgroup" followed by getAttribute() 
-FAIL td.scope: IDL set to "xrowgroup" followed by IDL get assert_equals: expected "" but got "xrowgroup"
+PASS td.scope: IDL set to "xrowgroup" followed by IDL get 
 PASS td.scope: IDL set to "rowgroup\0" should not throw 
 PASS td.scope: IDL set to "rowgroup\0" followed by getAttribute() 
-FAIL td.scope: IDL set to "rowgroup\0" followed by IDL get assert_equals: expected "" but got "rowgroup\0"
+PASS td.scope: IDL set to "rowgroup\0" followed by IDL get 
 PASS td.scope: IDL set to "owgroup" should not throw 
 PASS td.scope: IDL set to "owgroup" followed by getAttribute() 
-FAIL td.scope: IDL set to "owgroup" followed by IDL get assert_equals: expected "" but got "owgroup"
+PASS td.scope: IDL set to "owgroup" followed by IDL get 
 PASS td.scope: IDL set to "ROWGROUP" should not throw 
 PASS td.scope: IDL set to "ROWGROUP" followed by getAttribute() 
-FAIL td.scope: IDL set to "ROWGROUP" followed by IDL get assert_equals: expected "rowgroup" but got "ROWGROUP"
+PASS td.scope: IDL set to "ROWGROUP" followed by IDL get 
 PASS td.scope: IDL set to "colgroup" should not throw 
 PASS td.scope: IDL set to "colgroup" followed by getAttribute() 
 PASS td.scope: IDL set to "colgroup" followed by IDL get 
 PASS td.scope: IDL set to "xcolgroup" should not throw 
 PASS td.scope: IDL set to "xcolgroup" followed by getAttribute() 
-FAIL td.scope: IDL set to "xcolgroup" followed by IDL get assert_equals: expected "" but got "xcolgroup"
+PASS td.scope: IDL set to "xcolgroup" followed by IDL get 
 PASS td.scope: IDL set to "colgroup\0" should not throw 
 PASS td.scope: IDL set to "colgroup\0" followed by getAttribute() 
-FAIL td.scope: IDL set to "colgroup\0" followed by IDL get assert_equals: expected "" but got "colgroup\0"
+PASS td.scope: IDL set to "colgroup\0" followed by IDL get 
 PASS td.scope: IDL set to "olgroup" should not throw 
 PASS td.scope: IDL set to "olgroup" followed by getAttribute() 
-FAIL td.scope: IDL set to "olgroup" followed by IDL get assert_equals: expected "" but got "olgroup"
+PASS td.scope: IDL set to "olgroup" followed by IDL get 
 PASS td.scope: IDL set to "COLGROUP" should not throw 
 PASS td.scope: IDL set to "COLGROUP" followed by getAttribute() 
-FAIL td.scope: IDL set to "COLGROUP" followed by IDL get assert_equals: expected "colgroup" but got "COLGROUP"
+PASS td.scope: IDL set to "COLGROUP" followed by IDL get 
 PASS td.abbr: typeof IDL attribute 
 PASS td.abbr: IDL get with DOM attribute unset 
 PASS td.abbr: setAttribute() to "" followed by getAttribute() 

Modified: trunk/Source/WebCore/ChangeLog (206732 => 206733)


--- trunk/Source/WebCore/ChangeLog	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/Source/WebCore/ChangeLog	2016-10-03 16:23:24 UTC (rev 206733)
@@ -1,3 +1,20 @@
+2016-10-03  Chris Dumez  <[email protected]>
+
+        td.scope should only return known values
+        https://bugs.webkit.org/show_bug.cgi?id=162755
+
+        Reviewed by Sam Weinig.
+
+        td.scope should only return known values:
+        - https://html.spec.whatwg.org/#dom-th-scope
+
+        Firefox conforms to the specification.
+
+        No new tests, rebaselined existing test.
+
+        * html/HTMLTableCellElement.cpp:
+        (WebCore::HTMLTableCellElement::scope):
+
 2016-10-03  Carlos Garcia Campos  <[email protected]>
 
         [SOUP] Simplify AuthenticationChallenge

Modified: trunk/Source/WebCore/html/HTMLTableCellElement.cpp (206732 => 206733)


--- trunk/Source/WebCore/html/HTMLTableCellElement.cpp	2016-10-03 10:42:11 UTC (rev 206732)
+++ trunk/Source/WebCore/html/HTMLTableCellElement.cpp	2016-10-03 16:23:24 UTC (rev 206733)
@@ -169,10 +169,6 @@
 
     const AtomicString& value = attributeWithoutSynchronization(HTMLNames::scopeAttr);
 
-    // Only conforming for th elements.
-    if (!hasTagName(thTag))
-        return value;
-
     if (equalIgnoringASCIICase(value, row))
         return row;
     if (equalIgnoringASCIICase(value, col))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to