Title: [206740] trunk/Source/WebCore
- Revision
- 206740
- Author
- [email protected]
- Date
- 2016-10-03 12:13:20 -0700 (Mon, 03 Oct 2016)
Log Message
[SOUP] Remove unused methods toSoupMessage from ResourceRequest/Response
https://bugs.webkit.org/show_bug.cgi?id=162867
Patch by Carlos Garcia Campos <[email protected]> on 2016-10-03
Reviewed by Sergio Villar Senin.
* platform/network/soup/ResourceRequest.h:
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupMessage):
(WebCore::ResourceRequest::updateFromSoupMessage): Deleted.
* platform/network/soup/ResourceResponse.h:
* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (206739 => 206740)
--- trunk/Source/WebCore/ChangeLog 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/ChangeLog 2016-10-03 19:13:20 UTC (rev 206740)
@@ -1,3 +1,18 @@
+2016-10-03 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Remove unused methods toSoupMessage from ResourceRequest/Response
+ https://bugs.webkit.org/show_bug.cgi?id=162867
+
+ Reviewed by Sergio Villar Senin.
+
+ * platform/network/soup/ResourceRequest.h:
+ * platform/network/soup/ResourceRequestSoup.cpp:
+ (WebCore::ResourceRequest::updateSoupMessage):
+ (WebCore::ResourceRequest::updateFromSoupMessage): Deleted.
+ * platform/network/soup/ResourceResponse.h:
+ * platform/network/soup/ResourceResponseSoup.cpp:
+ (WebCore::ResourceResponse::updateFromSoupMessage): Deleted.
+
2016-10-03 Youenn Fablet <[email protected]>
Remove FetchBody::m_isEmpty
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequest.h (206739 => 206740)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequest.h 2016-10-03 19:13:20 UTC (rev 206740)
@@ -94,7 +94,6 @@
void updateSoupMessageHeaders(SoupMessageHeaders*) const;
void updateFromSoupMessageHeaders(SoupMessageHeaders*);
void updateSoupMessage(SoupMessage*) const;
- SoupMessage* toSoupMessage() const;
void updateFromSoupMessage(SoupMessage*);
void updateSoupRequest(SoupRequest*) const;
void updateFromSoupRequest(SoupRequest*);
Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp (206739 => 206740)
--- trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequestSoup.cpp 2016-10-03 19:13:20 UTC (rev 206740)
@@ -79,20 +79,6 @@
updateSoupMessageMembers(soupMessage);
}
-SoupMessage* ResourceRequest::toSoupMessage() const
-{
- SoupMessage* soupMessage = soup_message_new(httpMethod().ascii().data(), url().string().utf8().data());
- if (!soupMessage)
- return 0;
-
- updateSoupMessageMembers(soupMessage);
-
- // Body data is only handled at ResourceHandleSoup::startHttp for
- // now; this is because this may not be a good place to go
- // openning and mmapping files. We should maybe revisit this.
- return soupMessage;
-}
-
void ResourceRequest::updateFromSoupMessage(SoupMessage* soupMessage)
{
bool shouldPortBeResetToZero = m_url.hasPort() && !m_url.port();
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponse.h (206739 => 206740)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponse.h 2016-10-03 19:13:20 UTC (rev 206740)
@@ -56,7 +56,6 @@
updateFromSoupMessage(soupMessage);
}
- SoupMessage* toSoupMessage() const;
void updateSoupMessageHeaders(SoupMessageHeaders*) const;
void updateFromSoupMessage(SoupMessage*);
void updateFromSoupMessageHeaders(const SoupMessageHeaders*);
Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (206739 => 206740)
--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2016-10-03 18:36:55 UTC (rev 206739)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp 2016-10-03 19:13:20 UTC (rev 206740)
@@ -38,25 +38,6 @@
soup_message_headers_append(soupHeaders, header.key.utf8().data(), header.value.utf8().data());
}
-SoupMessage* ResourceResponse::toSoupMessage() const
-{
- // This GET here is just because SoupMessage wants it, we dn't really know.
- SoupMessage* soupMessage = soup_message_new("GET", url().string().utf8().data());
- if (!soupMessage)
- return 0;
-
- soupMessage->status_code = httpStatusCode();
-
- updateSoupMessageHeaders(soupMessage->response_headers);
-
- soup_message_set_flags(soupMessage, m_soupFlags);
-
- g_object_set(G_OBJECT(soupMessage), "tls-certificate", m_certificate.get(), "tls-errors", m_tlsErrors, NULL);
-
- // Body data is not in the message.
- return soupMessage;
-}
-
void ResourceResponse::updateFromSoupMessage(SoupMessage* soupMessage)
{
m_url = URL(soup_message_get_uri(soupMessage));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
