Title: [98560] trunk/Source/WebKit2
Revision
98560
Author
[email protected]
Date
2011-10-27 06:19:53 -0700 (Thu, 27 Oct 2011)

Log Message

[Qt][WK2] Remove QAction from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70525

This fixes the commonview tests that were failing
after r98447.
WebViewAbstraction must forward actions to both
the TouchWebView and the DesktopWebView.

Patch by Zeno Albisser <[email protected]> on 2011-10-27
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::goBack):
(WebViewAbstraction::goForward):
(WebViewAbstraction::stop):
(WebViewAbstraction::reload):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (98559 => 98560)


--- trunk/Source/WebKit2/ChangeLog	2011-10-27 13:07:23 UTC (rev 98559)
+++ trunk/Source/WebKit2/ChangeLog	2011-10-27 13:19:53 UTC (rev 98560)
@@ -1,3 +1,21 @@
+2011-10-27  Zeno Albisser  <[email protected]>
+
+        [Qt][WK2] Remove QAction from MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=70525
+
+        This fixes the commonview tests that were failing
+        after r98447.
+        WebViewAbstraction must forward actions to both
+        the TouchWebView and the DesktopWebView.
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        * UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
+        (WebViewAbstraction::goBack):
+        (WebViewAbstraction::goForward):
+        (WebViewAbstraction::stop):
+        (WebViewAbstraction::reload):
+
 2011-10-27  Zalan Bujtas  <[email protected]>
 
         [Qt][WK2]Content size changed event does not require viewport attribute calculation.

Modified: trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp (98559 => 98560)


--- trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp	2011-10-27 13:07:23 UTC (rev 98559)
+++ trunk/Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp	2011-10-27 13:19:53 UTC (rev 98560)
@@ -100,21 +100,25 @@
 void WebViewAbstraction::goBack()
 {
     touchWebView()->page()->navigationController()->goBack();
+    desktopWebView()->navigationController()->goBack();
 }
 
 void WebViewAbstraction::goForward()
 {
     touchWebView()->page()->navigationController()->goForward();
+    desktopWebView()->navigationController()->goForward();
 }
 
 void WebViewAbstraction::stop()
 {
     touchWebView()->page()->navigationController()->stop();
+    desktopWebView()->navigationController()->stop();
 }
 
 void WebViewAbstraction::reload()
 {
     touchWebView()->page()->navigationController()->reload();
+    desktopWebView()->navigationController()->reload();
 }
 
 void WebViewAbstraction::touchViewLoadStarted()
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to