Title: [206970] trunk/Tools
- Revision
- 206970
- Author
- [email protected]
- Date
- 2016-10-09 15:47:57 -0700 (Sun, 09 Oct 2016)
Log Message
Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
https://bugs.webkit.org/show_bug.cgi?id=163177
Follow-up fix.
For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
Rename it to as_dict().
* Scripts/webkitpy/common/config/committers.py:
(Contributor.as_dict):
(CommitterList._contributor_list_to_dict):
(Contributor.__dict__): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (206969 => 206970)
--- trunk/Tools/ChangeLog 2016-10-09 20:47:47 UTC (rev 206969)
+++ trunk/Tools/ChangeLog 2016-10-09 22:47:57 UTC (rev 206970)
@@ -1,3 +1,18 @@
+2016-10-09 Simon Fraser <[email protected]>
+
+ Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
+ https://bugs.webkit.org/show_bug.cgi?id=163177
+
+ Follow-up fix.
+
+ For unknown reasons, overriding Commiter.__dict__() caused mysterious test failures.
+ Rename it to as_dict().
+
+ * Scripts/webkitpy/common/config/committers.py:
+ (Contributor.as_dict):
+ (CommitterList._contributor_list_to_dict):
+ (Contributor.__dict__): Deleted.
+
2016-10-08 Simon Fraser <[email protected]>
Add support for canonicalizing contributors.json, and have check-webkit-style check the format.
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (206969 => 206970)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-09 20:47:47 UTC (rev 206969)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-09 22:47:57 UTC (rev 206970)
@@ -92,7 +92,7 @@
return True
return False
- def __dict__(self):
+ def as_dict(self):
info = {"emails" : self._case_preserved_emails}
if self.irc_nicknames:
@@ -156,7 +156,7 @@
def _contributor_list_to_dict(list):
committers_dict = {}
for contributor in sorted(list):
- committers_dict[contributor.full_name] = contributor.__dict__()
+ committers_dict[contributor.full_name] = contributor.as_dict()
return committers_dict
def as_json(self):
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
