Title: [207006] trunk/Source/WebInspectorUI
- Revision
- 207006
- Author
- [email protected]
- Date
- 2016-10-10 10:23:07 -0700 (Mon, 10 Oct 2016)
Log Message
Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
https://bugs.webkit.org/show_bug.cgi?id=163197
Reviewed by Timothy Hatcher.
* UserInterface/Views/TextEditor.js:
(WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
Avoid highlighting the execution line while debugging, but allow
other lines to be highlighted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (207005 => 207006)
--- trunk/Source/WebInspectorUI/ChangeLog 2016-10-10 17:17:41 UTC (rev 207005)
+++ trunk/Source/WebInspectorUI/ChangeLog 2016-10-10 17:23:07 UTC (rev 207006)
@@ -1,3 +1,15 @@
+2016-10-10 Matt Baker <[email protected]>
+
+ Web Inspector: Revealed line not highlighted in TextEditor while debugger paused
+ https://bugs.webkit.org/show_bug.cgi?id=163197
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TextEditor.js:
+ (WebInspector.TextEditor.prototype.revealPosition.revealAndHighlightLine):
+ Avoid highlighting the execution line while debugging, but allow
+ other lines to be highlighted.
+
2016-10-06 Devin Rousso <[email protected]>
Inspector exception in `parseTextForRule()` when pasting into CSS rule selector
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (207005 => 207006)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2016-10-10 17:17:41 UTC (rev 207005)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js 2016-10-10 17:23:07 UTC (rev 207006)
@@ -497,9 +497,8 @@
if (noHighlight)
return;
- // Don't show blue line highlight when debugging.
- // FIXME: This could be better, we could avoid highlight only when switching for active call frames switches.
- if (WebInspector.debuggerManager.paused)
+ // Avoid highlighting the execution line while debugging.
+ if (WebInspector.debuggerManager.paused && (!this._executionLineNumber || line === this._executionLineNumber))
return;
this._codeMirror.addLineClass(lineHandle, "wrap", WebInspector.TextEditor.HighlightedStyleClassName);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
