Title: [207121] releases/WebKitGTK/webkit-2.14/Source/WebCore
Revision
207121
Author
[email protected]
Date
2016-10-11 06:24:16 -0700 (Tue, 11 Oct 2016)

Log Message

Merge r206825 - [GTK] Improve comment in platformVersionForUAString
https://bugs.webkit.org/show_bug.cgi?id=162612

Reviewed by Carlos Garcia Campos.

* platform/gtk/UserAgentGtk.cpp:
(WebCore::platformVersionForUAString):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog (207120 => 207121)


--- releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog	2016-10-11 13:24:09 UTC (rev 207120)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/ChangeLog	2016-10-11 13:24:16 UTC (rev 207121)
@@ -1,3 +1,13 @@
+2016-10-05  Michael Catanzaro  <[email protected]>
+
+        [GTK] Improve comment in platformVersionForUAString
+        https://bugs.webkit.org/show_bug.cgi?id=162612
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/gtk/UserAgentGtk.cpp:
+        (WebCore::platformVersionForUAString):
+
 2016-09-28  Michael Catanzaro  <[email protected]>
 
         [GTK] Add Chrome UA quirk

Modified: releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp (207120 => 207121)


--- releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2016-10-11 13:24:09 UTC (rev 207120)
+++ releases/WebKitGTK/webkit-2.14/Source/WebCore/platform/gtk/UserAgentGtk.cpp	2016-10-11 13:24:16 UTC (rev 207121)
@@ -94,8 +94,10 @@
     static NeverDestroyed<const String> uaOSVersion(String::format("%s %s", name.sysname, name.machine));
     return uaOSVersion;
 #else
-    // We will always claim to be Safari in Mac OS X, since Safari in Linux triggers the iOS path on some websites.
-    // And we always claim to be Intel since ARM triggers mobile versions of some websites.
+    // We will always claim to be Safari in Intel Mac OS X, since Safari without
+    // OS X or anything on ARM triggers mobile versions of some websites.
+    //
+    // FIXME: The final result should include OS version, e.g. "Intel Mac OS X 10_8_4".
     static NeverDestroyed<const String> uaOSVersion(ASCIILiteral("Intel Mac OS X"));
     return uaOSVersion;
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to