Title: [207135] trunk/LayoutTests
- Revision
- 207135
- Author
- [email protected]
- Date
- 2016-10-11 07:06:29 -0700 (Tue, 11 Oct 2016)
Log Message
[mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=163248
Patch by Antoine Quint <[email protected]> on 2016-10-11
Reviewed by Antoine Quint.
Wait until all icon images are loaded before running the assertions. We can determine whether
a button's icon image is loaded by checking it's been sized.
* TestExpectations:
* media/modern-media-controls/airplay-button/airplay-button.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (207134 => 207135)
--- trunk/LayoutTests/ChangeLog 2016-10-11 13:58:42 UTC (rev 207134)
+++ trunk/LayoutTests/ChangeLog 2016-10-11 14:06:29 UTC (rev 207135)
@@ -1,5 +1,18 @@
2016-10-11 Antoine Quint <[email protected]>
+ [mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=163248
+
+ Reviewed by Antoine Quint.
+
+ Wait until all icon images are loaded before running the assertions. We can determine whether
+ a button's icon image is loaded by checking it's been sized.
+
+ * TestExpectations:
+ * media/modern-media-controls/airplay-button/airplay-button.html:
+
+2016-10-11 Antoine Quint <[email protected]>
+
[Modern Media Controls] Buttons container
https://bugs.webkit.org/show_bug.cgi?id=163238
<rdar://problem/28701864>
Modified: trunk/LayoutTests/TestExpectations (207134 => 207135)
--- trunk/LayoutTests/TestExpectations 2016-10-11 13:58:42 UTC (rev 207134)
+++ trunk/LayoutTests/TestExpectations 2016-10-11 14:06:29 UTC (rev 207135)
@@ -986,5 +986,4 @@
# Only iOS has implemented lettepress.
fast/text/letterpress-different.html [ ImageOnlyFailure ]
-webkit.org/b/163248 media/modern-media-controls/airplay-button/airplay-button.html [ Failure ]
webkit.org/b/163249 media/modern-media-controls/play-pause-button/play-pause-button.html [ Failure ]
Modified: trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html (207134 => 207135)
--- trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2016-10-11 13:58:42 UTC (rev 207134)
+++ trunk/LayoutTests/media/modern-media-controls/airplay-button/airplay-button.html 2016-10-11 14:06:29 UTC (rev 207135)
@@ -31,6 +31,9 @@
scheduler.frameDidFire = function()
{
+ if ([airplayButton, macOSFullscreenAirplayButton, iOSAirplayButton].some(button => button.width == 0))
+ return;
+
shouldBeTrue('airplayButton.element.style.webkitMaskImage.includes("macOS/airplay@")');
shouldBeTrue('macOSFullscreenAirplayButton.element.style.webkitMaskImage.includes("macOS/airplay-fullscreen@")');
shouldBeTrue('iOSAirplayButton.element.style.webkitMaskImage.includes("iOS/airplay@")');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
