Title: [207138] trunk/LayoutTests
- Revision
- 207138
- Author
- [email protected]
- Date
- 2016-10-11 07:57:55 -0700 (Tue, 11 Oct 2016)
Log Message
[mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=163249
Patch by Antoine Quint <[email protected]> on 2016-10-11
Reviewed by Antoine Quint.
Wait until all icon images are loaded before running the assertions. We can determine whether
a button's icon image is loaded by checking it's been sized.
* TestExpectations:
* media/modern-media-controls/play-pause-button/play-pause-button.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (207137 => 207138)
--- trunk/LayoutTests/ChangeLog 2016-10-11 14:30:10 UTC (rev 207137)
+++ trunk/LayoutTests/ChangeLog 2016-10-11 14:57:55 UTC (rev 207138)
@@ -1,5 +1,18 @@
2016-10-11 Antoine Quint <[email protected]>
+ [mac] LayoutTest media/modern-media-controls/play-pause-button/play-pause-button.html is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=163249
+
+ Reviewed by Antoine Quint.
+
+ Wait until all icon images are loaded before running the assertions. We can determine whether
+ a button's icon image is loaded by checking it's been sized.
+
+ * TestExpectations:
+ * media/modern-media-controls/play-pause-button/play-pause-button.html:
+
+2016-10-11 Antoine Quint <[email protected]>
+
[mac] LayoutTest media/modern-media-controls/airplay-button/airplay-button.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=163248
Modified: trunk/LayoutTests/TestExpectations (207137 => 207138)
--- trunk/LayoutTests/TestExpectations 2016-10-11 14:30:10 UTC (rev 207137)
+++ trunk/LayoutTests/TestExpectations 2016-10-11 14:57:55 UTC (rev 207138)
@@ -986,4 +986,3 @@
# Only iOS has implemented lettepress.
fast/text/letterpress-different.html [ ImageOnlyFailure ]
-webkit.org/b/163249 media/modern-media-controls/play-pause-button/play-pause-button.html [ Failure ]
Modified: trunk/LayoutTests/media/modern-media-controls/play-pause-button/play-pause-button.html (207137 => 207138)
--- trunk/LayoutTests/media/modern-media-controls/play-pause-button/play-pause-button.html 2016-10-11 14:30:10 UTC (rev 207137)
+++ trunk/LayoutTests/media/modern-media-controls/play-pause-button/play-pause-button.html 2016-10-11 14:57:55 UTC (rev 207138)
@@ -41,6 +41,9 @@
scheduler.frameDidFire = function()
{
+ if ([playButton, pauseButton, iOSPlayButton, iOSPauseButton, fullscreenPlayButton, fullscreenPauseButton].some(button => button.width == 0))
+ return;
+
shouldBeTrue('playButton.element.style.webkitMaskImage.includes("macOS/play@")');
shouldBeTrue('pauseButton.element.style.webkitMaskImage.includes("macOS/pause@")');
shouldBeTrue('iOSPlayButton.element.style.webkitMaskImage.includes("iOS/play@")');
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
