Title: [207167] trunk/Tools
- Revision
- 207167
- Author
- [email protected]
- Date
- 2016-10-11 14:58:20 -0700 (Tue, 11 Oct 2016)
Log Message
Update API test expectation after r207162.
https://bugs.webkit.org/show_bug.cgi?id=162660
* TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
"https://www.example.com<>/" was an invalid URL with the old URL parser.
It is now a valid URL, but NSURL still considers it invalid.
This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (207166 => 207167)
--- trunk/Tools/ChangeLog 2016-10-11 21:33:11 UTC (rev 207166)
+++ trunk/Tools/ChangeLog 2016-10-11 21:58:20 UTC (rev 207167)
@@ -1,3 +1,14 @@
+2016-10-11 Alex Christensen <[email protected]>
+
+ Update API test expectation after r207162.
+ https://bugs.webkit.org/show_bug.cgi?id=162660
+
+ * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
+ (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
+ "https://www.example.com<>/" was an invalid URL with the old URL parser.
+ It is now a valid URL, but NSURL still considers it invalid.
+ This will be looked into more with https://bugs.webkit.org/show_bug.cgi?id=163127
+
2016-10-11 Edward O'Connor <[email protected]>
Update my name in contributors.json
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm (207166 => 207167)
--- trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm 2016-10-11 21:33:11 UTC (rev 207166)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm 2016-10-11 21:58:20 UTC (rev 207167)
@@ -47,8 +47,8 @@
- (void)webView:(WebView *)sender didFailProvisionalLoadWithError:(NSError *)error forFrame:(WebFrame *)frame
{
- EXPECT_WK_STREQ(error.domain, @"WebKitErrorDomain");
- EXPECT_EQ(error.code, WebKitErrorCannotShowURL);
+ EXPECT_WK_STREQ(error.domain, @"NSURLErrorDomain");
+ EXPECT_EQ(error.code, -1003);
static char literal[] = "https://www.example.com<>/";
NSURL *failedURL = WebCore::URLWithData([NSData dataWithBytes:literal length:strlen(literal)], nil);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
