Title: [207171] trunk/Source
Revision
207171
Author
[email protected]
Date
2016-10-11 15:19:02 -0700 (Tue, 11 Oct 2016)

Log Message

Attempt to fix the Apple Internal Mac build following r207159
(https://bugs.webkit.org/show_bug.cgi?id=163244)

Source/WebKit/mac:

* WebView/WebView.mm:
(shouldRequireUserGestureToLoadVideo):

Source/WebKit2:

* UIProcess/API/Cocoa/WKWebView.mm:
(shouldRequireUserGestureToLoadVideo):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (207170 => 207171)


--- trunk/Source/WebKit/mac/ChangeLog	2016-10-11 22:07:50 UTC (rev 207170)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-10-11 22:19:02 UTC (rev 207171)
@@ -1,5 +1,13 @@
 2016-10-11  Daniel Bates  <[email protected]>
 
+        Attempt to fix the Apple Internal Mac build following r207159
+        (https://bugs.webkit.org/show_bug.cgi?id=163244)
+
+        * WebView/WebView.mm:
+        (shouldRequireUserGestureToLoadVideo):
+
+2016-10-11  Daniel Bates  <[email protected]>
+
         REGRESSION (r198251): -[UIWebView mediaPlaybackRequiresUserAction] defaults to NO
         https://bugs.webkit.org/show_bug.cgi?id=163259
         <rdar://problem/28680515>

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (207170 => 207171)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2016-10-11 22:07:50 UTC (rev 207170)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2016-10-11 22:19:02 UTC (rev 207171)
@@ -905,8 +905,12 @@
 
 static bool shouldRequireUserGestureToLoadVideo()
 {
+#if PLATFORM(IOS)
     static bool shouldRequireUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
     return shouldRequireUserGestureToLoadVideo;
+#else
+    return true;
+#endif
 }
 
 #if ENABLE(GAMEPAD)

Modified: trunk/Source/WebKit2/ChangeLog (207170 => 207171)


--- trunk/Source/WebKit2/ChangeLog	2016-10-11 22:07:50 UTC (rev 207170)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-11 22:19:02 UTC (rev 207171)
@@ -1,3 +1,11 @@
+2016-10-11  Daniel Bates  <[email protected]>
+
+        Attempt to fix the Apple Internal Mac build following r207159
+        (https://bugs.webkit.org/show_bug.cgi?id=163244)
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (shouldRequireUserGestureToLoadVideo):
+
 2016-10-11  Anders Carlsson  <[email protected]>
 
         Clean up WebPageGroup somewhat

Modified: trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm (207170 => 207171)


--- trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-10-11 22:07:50 UTC (rev 207170)
+++ trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm	2016-10-11 22:19:02 UTC (rev 207171)
@@ -328,8 +328,12 @@
 
 static bool shouldRequireUserGestureToLoadVideo()
 {
+#if PLATFORM(IOS)
     static bool shouldRequireUserGestureToLoadVideo = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_10_0;
     return shouldRequireUserGestureToLoadVideo;
+#else
+    return true;
+#endif
 }
 
 #if ENABLE(DATA_DETECTION) && PLATFORM(IOS)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to