Title: [207277] trunk
Revision
207277
Author
cdu...@apple.com
Date
2016-10-12 22:18:59 -0700 (Wed, 12 Oct 2016)

Log Message

Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]
https://bugs.webkit.org/show_bug.cgi?id=163369

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop
using legacy [ConstructorTemplate=Event] and use regular constructors
instead.

This also adds support for having dictionary members that are typed
arrays because this was needed.

Test: fast/events/webkit-media-key-events-constructor.html

* Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp:
(WebCore::WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent):
* Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h:
(WebCore::WebKitMediaKeyMessageEvent::create):
(WebCore::WebKitMediaKeyMessageEvent::createForBindings): Deleted.
* Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
* Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp:
(WebCore::WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent):
* Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h:
(WebCore::WebKitMediaKeyNeededEvent::create):
(WebCore::WebKitMediaKeyNeededEvent::createForBindings): Deleted.
* Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
* bindings/js/JSDOMConvert.h:
(WebCore::Converter<IDLInterface<JSC::GenericTypedArrayView<Adaptor>>>::convert):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDefaultValue):
* dom/InputEvent.cpp:
(WebCore::InputEvent::InputEvent):
* dom/InputEvent.h:
* dom/InputEvent.idl:

LayoutTests:

Add layout test coverage.

* fast/events/webkit-media-key-events-constructor-expected.txt: Added.
* fast/events/webkit-media-key-events-constructor.html: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (207276 => 207277)


--- trunk/LayoutTests/ChangeLog	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/LayoutTests/ChangeLog	2016-10-13 05:18:59 UTC (rev 207277)
@@ -1,5 +1,17 @@
 2016-10-12  Chris Dumez  <cdu...@apple.com>
 
+        Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163369
+
+        Reviewed by Ryosuke Niwa.
+
+        Add layout test coverage.
+
+        * fast/events/webkit-media-key-events-constructor-expected.txt: Added.
+        * fast/events/webkit-media-key-events-constructor.html: Added.
+
+2016-10-12  Chris Dumez  <cdu...@apple.com>
+
         Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements
         https://bugs.webkit.org/show_bug.cgi?id=163358
 

Added: trunk/LayoutTests/fast/events/webkit-media-key-events-constructor-expected.txt (0 => 207277)


--- trunk/LayoutTests/fast/events/webkit-media-key-events-constructor-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/fast/events/webkit-media-key-events-constructor-expected.txt	2016-10-13 05:18:59 UTC (rev 207277)
@@ -0,0 +1,35 @@
+Test the WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent constructors.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+event = new WebKitMediaKeyMessageEvent("foo")
+PASS event.type is "foo"
+PASS event.bubbles is false
+PASS event.cancelable is false
+PASS event.message is null
+PASS event.destinationURL is ""
+
+event = new WebKitMediaKeyMessageEvent("foo", { bubbles: true, cancelable: true, message: testMessage, destinationURL: "testURL" })
+PASS event.type is "foo"
+PASS event.bubbles is true
+PASS event.cancelable is true
+PASS event.message is testMessage
+PASS event.destinationURL is "testURL"
+
+event = new WebKitMediaKeyNeededEvent("foo")
+PASS event.type is "foo"
+PASS event.bubbles is false
+PASS event.cancelable is false
+PASS event.initData is null
+
+event = new WebKitMediaKeyNeededEvent("foo", { bubbles: true, cancelable: true, initData: testMessage })
+PASS event.type is "foo"
+PASS event.bubbles is true
+PASS event.cancelable is true
+PASS event.initData is testMessage
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+

Added: trunk/LayoutTests/fast/events/webkit-media-key-events-constructor.html (0 => 207277)


--- trunk/LayoutTests/fast/events/webkit-media-key-events-constructor.html	                        (rev 0)
+++ trunk/LayoutTests/fast/events/webkit-media-key-events-constructor.html	2016-10-13 05:18:59 UTC (rev 207277)
@@ -0,0 +1,42 @@
+<!DOCTYPE html>
+<html>
+<body>
+<script src=""
+<script>
+description("Test the WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent constructors.");
+
+evalAndLog('event = new WebKitMediaKeyMessageEvent("foo")');
+shouldBeEqualToString("event.type", "foo");
+shouldBeFalse("event.bubbles");
+shouldBeFalse("event.cancelable");
+shouldBeNull("event.message");
+shouldBeEqualToString("event.destinationURL", "");
+debug("");
+
+var testMessage = new Uint8Array(8);
+evalAndLog('event = new WebKitMediaKeyMessageEvent("foo", { bubbles: true, cancelable: true, message: testMessage, destinationURL: "testURL" })');
+shouldBeEqualToString("event.type", "foo");
+shouldBeTrue("event.bubbles");
+shouldBeTrue("event.cancelable");
+shouldBe("event.message", "testMessage");
+shouldBeEqualToString("event.destinationURL", "testURL");
+debug("");
+
+evalAndLog('event = new WebKitMediaKeyNeededEvent("foo")');
+shouldBeEqualToString("event.type", "foo");
+shouldBeFalse("event.bubbles");
+shouldBeFalse("event.cancelable");
+shouldBeNull("event.initData");
+debug("");
+
+evalAndLog('event = new WebKitMediaKeyNeededEvent("foo", { bubbles: true, cancelable: true, initData: testMessage })');
+shouldBeEqualToString("event.type", "foo");
+shouldBeTrue("event.bubbles");
+shouldBeTrue("event.cancelable");
+shouldBe("event.initData", "testMessage");
+debug("");
+
+</script>
+<script src=""
+</body>
+</html>

Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (207276 => 207277)


--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-10-13 05:18:59 UTC (rev 207277)
@@ -2656,6 +2656,9 @@
 
 fast/events/page-visibility-iframe-move-test.html [ Skip ]
 
+# LEGACY_ENCRYPTED_MEDIA is disabled on iOS.
+fast/events/webkit-media-key-events-constructor.html [ Failure ]
+
 webkit.org/b/161143 imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html [ Pass Failure ]
 
 webkit.org/b/161395 svg/animations/reinserting-svg-into-document.html [ Pass Failure ]
@@ -2705,4 +2708,4 @@
 webkit.org/b/163307 [ Debug ] loader/stateobjects/pushstate-size-iframe.html [ Skip ]
 webkit.org/b/163307 [ Debug ] loader/stateobjects/pushstate-size.html [ Skip ]
 webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size-iframe.html [ Skip ]
-webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size.html [ Skip ]
\ No newline at end of file
+webkit.org/b/163307 [ Debug ] loader/stateobjects/replacestate-size.html [ Skip ]

Modified: trunk/Source/WebCore/ChangeLog (207276 => 207277)


--- trunk/Source/WebCore/ChangeLog	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/ChangeLog	2016-10-13 05:18:59 UTC (rev 207277)
@@ -1,5 +1,42 @@
 2016-10-12  Chris Dumez  <cdu...@apple.com>
 
+        Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]
+        https://bugs.webkit.org/show_bug.cgi?id=163369
+
+        Reviewed by Ryosuke Niwa.
+
+        Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop
+        using legacy [ConstructorTemplate=Event] and use regular constructors
+        instead.
+
+        This also adds support for having dictionary members that are typed
+        arrays because this was needed.
+
+        Test: fast/events/webkit-media-key-events-constructor.html
+
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp:
+        (WebCore::WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent):
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h:
+        (WebCore::WebKitMediaKeyMessageEvent::create):
+        (WebCore::WebKitMediaKeyMessageEvent::createForBindings): Deleted.
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl:
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp:
+        (WebCore::WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent):
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h:
+        (WebCore::WebKitMediaKeyNeededEvent::create):
+        (WebCore::WebKitMediaKeyNeededEvent::createForBindings): Deleted.
+        * Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl:
+        * bindings/js/JSDOMConvert.h:
+        (WebCore::Converter<IDLInterface<JSC::GenericTypedArrayView<Adaptor>>>::convert):
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateDefaultValue):
+        * dom/InputEvent.cpp:
+        (WebCore::InputEvent::InputEvent):
+        * dom/InputEvent.h:
+        * dom/InputEvent.idl:
+
+2016-10-12  Chris Dumez  <cdu...@apple.com>
+
         Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements
         https://bugs.webkit.org/show_bug.cgi?id=163358
 

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.cpp	2016-10-13 05:18:59 UTC (rev 207277)
@@ -41,8 +41,8 @@
 }
 
 
-WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent(const AtomicString& type, const WebKitMediaKeyMessageEventInit& initializer)
-    : Event(type, initializer)
+WebKitMediaKeyMessageEvent::WebKitMediaKeyMessageEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+    : Event(type, initializer, isTrusted)
     , m_message(initializer.message)
     , m_destinationURL(initializer.destinationURL)
 {

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h	2016-10-13 05:18:59 UTC (rev 207277)
@@ -34,11 +34,6 @@
 
 namespace WebCore {
 
-struct WebKitMediaKeyMessageEventInit : public EventInit {
-    RefPtr<Uint8Array> message;
-    String destinationURL;
-};
-
 class WebKitMediaKeyMessageEvent : public Event {
 public:
     virtual ~WebKitMediaKeyMessageEvent();
@@ -48,9 +43,14 @@
         return adoptRef(*new WebKitMediaKeyMessageEvent(type, message, destinationURL));
     }
 
-    static Ref<WebKitMediaKeyMessageEvent> createForBindings(const AtomicString& type, const WebKitMediaKeyMessageEventInit& initializer)
+    struct Init : EventInit {
+        RefPtr<Uint8Array> message;
+        String destinationURL;
+    };
+
+    static Ref<WebKitMediaKeyMessageEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new WebKitMediaKeyMessageEvent(type, initializer));
+        return adoptRef(*new WebKitMediaKeyMessageEvent(type, initializer, isTrusted));
     }
 
     EventInterface eventInterface() const override;
@@ -60,7 +60,7 @@
 
 private:
     WebKitMediaKeyMessageEvent(const AtomicString& type, Uint8Array* message, const String& destinationURL);
-    WebKitMediaKeyMessageEvent(const AtomicString& type, const WebKitMediaKeyMessageEventInit& initializer);
+    WebKitMediaKeyMessageEvent(const AtomicString& type, const Init&, IsTrusted);
 
     RefPtr<Uint8Array> m_message;
     String m_destinationURL;

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.idl	2016-10-13 05:18:59 UTC (rev 207277)
@@ -25,9 +25,13 @@
 
 [
     Conditional=LEGACY_ENCRYPTED_MEDIA,
-    ConstructorTemplate=Event,
+    Constructor(DOMString type, optional WebKitMediaKeyMessageEventInit eventInitDict),
 ] interface WebKitMediaKeyMessageEvent : Event {
     readonly attribute Uint8Array message;
-    [InitializedByEventConstructor] readonly attribute DOMString destinationURL;
+    readonly attribute DOMString destinationURL;
 };
 
+dictionary WebKitMediaKeyMessageEventInit : EventInit {
+    Uint8Array? message = null;
+    DOMString destinationURL = "";
+};

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.cpp	2016-10-13 05:18:59 UTC (rev 207277)
@@ -39,8 +39,8 @@
 {
 }
 
-WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent(const AtomicString& type, const WebKitMediaKeyNeededEventInit& initializer)
-    : Event(type, initializer)
+WebKitMediaKeyNeededEvent::WebKitMediaKeyNeededEvent(const AtomicString& type, const Init& initializer, IsTrusted isTrusted)
+    : Event(type, initializer, isTrusted)
     , m_initData(initializer.initData)
 {
 }

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h	2016-10-13 05:18:59 UTC (rev 207277)
@@ -33,10 +33,6 @@
 
 namespace WebCore {
 
-struct WebKitMediaKeyNeededEventInit : public EventInit {
-    RefPtr<Uint8Array> initData;
-};
-
 class WebKitMediaKeyNeededEvent : public Event {
 public:
     virtual ~WebKitMediaKeyNeededEvent();
@@ -46,9 +42,13 @@
         return adoptRef(*new WebKitMediaKeyNeededEvent(type, initData));
     }
 
-    static Ref<WebKitMediaKeyNeededEvent> createForBindings(const AtomicString& type, const WebKitMediaKeyNeededEventInit& initializer)
+    struct Init : EventInit {
+        RefPtr<Uint8Array> initData;
+    };
+
+    static Ref<WebKitMediaKeyNeededEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new WebKitMediaKeyNeededEvent(type, initializer));
+        return adoptRef(*new WebKitMediaKeyNeededEvent(type, initializer, isTrusted));
     }
 
     EventInterface eventInterface() const override;
@@ -57,7 +57,7 @@
 
 private:
     WebKitMediaKeyNeededEvent(const AtomicString& type, Uint8Array* initData);
-    WebKitMediaKeyNeededEvent(const AtomicString& type, const WebKitMediaKeyNeededEventInit& initializer);
+    WebKitMediaKeyNeededEvent(const AtomicString& type, const Init&, IsTrusted);
 
     RefPtr<Uint8Array> m_initData;
 };

Modified: trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl (207276 => 207277)


--- trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.idl	2016-10-13 05:18:59 UTC (rev 207277)
@@ -25,8 +25,11 @@
 
 [
     Conditional=LEGACY_ENCRYPTED_MEDIA,
-    ConstructorTemplate=Event 
+    Constructor(DOMString type, optional WebKitMediaKeyNeededEventInit eventInitDict),
 ] interface WebKitMediaKeyNeededEvent : Event {
     readonly attribute Uint8Array initData;
 };
 
+dictionary WebKitMediaKeyNeededEventInit : EventInit {
+    Uint8Array? initData = null;
+};

Modified: trunk/Source/WebCore/bindings/js/JSDOMConvert.h (207276 => 207277)


--- trunk/Source/WebCore/bindings/js/JSDOMConvert.h	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvert.h	2016-10-13 05:18:59 UTC (rev 207277)
@@ -121,6 +121,28 @@
     }
 };
 
+
+// Typed arrays support.
+
+template<typename Adaptor> struct IDLInterface<JSC::GenericTypedArrayView<Adaptor>> : IDLType<Ref<JSC::GenericTypedArrayView<Adaptor>>> {
+    using RawType = JSC::GenericTypedArrayView<Adaptor>;
+    using NullableType = RefPtr<JSC::GenericTypedArrayView<Adaptor>>;
+};
+
+template<typename Adaptor> struct Converter<IDLInterface<JSC::GenericTypedArrayView<Adaptor>>> : DefaultConverter<IDLInterface<JSC::GenericTypedArrayView<Adaptor>>> {
+    using ReturnType = RefPtr<JSC::GenericTypedArrayView<Adaptor>>;
+
+    static ReturnType convert(JSC::ExecState& state, JSC::JSValue value)
+    {
+        JSC::VM& vm = state.vm();
+        auto scope = DECLARE_THROW_SCOPE(vm);
+        ReturnType object = JSC::toNativeTypedView<Adaptor>(value);
+        if (!object)
+            throwTypeError(&state, scope);
+        return object;
+    }
+};
+
 // MARK: -
 // MARK: Any type
 

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (207276 => 207277)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-10-13 05:18:59 UTC (rev 207277)
@@ -995,7 +995,7 @@
     }
     if ($defaultValue eq "null") {
         return "jsNull()" if $member->type eq "any";
-        return "nullptr" if $codeGenerator->IsWrapperType($member->type);
+        return "nullptr" if $codeGenerator->IsWrapperType($member->type) || $codeGenerator->IsTypedArrayType($member->type);
         return "String()" if $codeGenerator->IsStringType($member->type);
         return "Nullopt";
     }

Modified: trunk/Source/WebCore/dom/InputEvent.cpp (207276 => 207277)


--- trunk/Source/WebCore/dom/InputEvent.cpp	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/dom/InputEvent.cpp	2016-10-13 05:18:59 UTC (rev 207277)
@@ -41,8 +41,8 @@
 {
 }
 
-InputEvent::InputEvent(const AtomicString& eventType, const InputEventInit& initializer)
-    : UIEvent(eventType, initializer)
+InputEvent::InputEvent(const AtomicString& eventType, const Init& initializer, IsTrusted isTrusted)
+    : UIEvent(eventType, initializer, isTrusted)
     , m_inputType(emptyString())
     , m_data(initializer.data)
 {

Modified: trunk/Source/WebCore/dom/InputEvent.h (207276 => 207277)


--- trunk/Source/WebCore/dom/InputEvent.h	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/dom/InputEvent.h	2016-10-13 05:18:59 UTC (rev 207277)
@@ -32,11 +32,6 @@
 class DOMWindow;
 class DataTransfer;
 
-struct InputEventInit : UIEventInit {
-    String data;
-    bool isComposing;
-};
-
 class InputEvent final : public UIEvent {
 public:
     static Ref<InputEvent> create(const AtomicString& eventType, const String& inputType, bool canBubble, bool cancelable, DOMWindow* view, const String& data, int detail)
@@ -44,13 +39,17 @@
         return adoptRef(*new InputEvent(eventType, inputType, canBubble, cancelable, view, data, detail));
     }
 
-    static Ref<InputEvent> createForBindings(const AtomicString& type, const InputEventInit& initializer)
+    struct Init : UIEventInit {
+        String data;
+    };
+
+    static Ref<InputEvent> create(const AtomicString& type, const Init& initializer, IsTrusted isTrusted = IsTrusted::No)
     {
-        return adoptRef(*new InputEvent(type, initializer));
+        return adoptRef(*new InputEvent(type, initializer, isTrusted));
     }
 
     InputEvent(const AtomicString& eventType, const String& inputType, bool canBubble, bool cancelable, DOMWindow*, const String& data, int detail);
-    InputEvent(const AtomicString& eventType, const InputEventInit&);
+    InputEvent(const AtomicString& eventType, const Init&, IsTrusted);
 
     virtual ~InputEvent() { }
 

Modified: trunk/Source/WebCore/dom/InputEvent.idl (207276 => 207277)


--- trunk/Source/WebCore/dom/InputEvent.idl	2016-10-13 04:13:49 UTC (rev 207276)
+++ trunk/Source/WebCore/dom/InputEvent.idl	2016-10-13 05:18:59 UTC (rev 207277)
@@ -24,8 +24,12 @@
 */
 
 [
-    ConstructorTemplate=Event
+    Constructor(DOMString type, optional InputEventInit eventInitDict),
 ] interface InputEvent : UIEvent {
     readonly attribute DOMString inputType;
-    [InitializedByEventConstructor] readonly attribute DOMString? data;
+    readonly attribute DOMString? data;
 };
+
+dictionary InputEventInit : UIEventInit {
+    DOMString? data = ""
+};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to