Title: [207332] trunk/Source/WebCore
- Revision
- 207332
- Author
- zandober...@gmail.com
- Date
- 2016-10-14 02:17:55 -0700 (Fri, 14 Oct 2016)
Log Message
[Cairo] GraphicsContext3D::ImageExtractor fails to extract images
https://bugs.webkit.org/show_bug.cgi?id=163439
Reviewed by Carlos Garcia Campos.
In the Cairo implementation of GraphicsContext3D::ImageExtractor,
don't check for frame completeness at index 0. This information
is now cached only after the frame for that index is decoded and
marked as completed, which is done after this check.
Becuase of this the current check forces extractImage() to return
early and abort WebGL texture uploads from image sources.
This bug was most likely exposed after the refactoring in r206481.
https://trac.webkit.org/changeset/206481
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (207331 => 207332)
--- trunk/Source/WebCore/ChangeLog 2016-10-14 09:04:24 UTC (rev 207331)
+++ trunk/Source/WebCore/ChangeLog 2016-10-14 09:17:55 UTC (rev 207332)
@@ -1,3 +1,24 @@
+2016-10-14 Zan Dobersek <zdober...@igalia.com>
+
+ [Cairo] GraphicsContext3D::ImageExtractor fails to extract images
+ https://bugs.webkit.org/show_bug.cgi?id=163439
+
+ Reviewed by Carlos Garcia Campos.
+
+ In the Cairo implementation of GraphicsContext3D::ImageExtractor,
+ don't check for frame completeness at index 0. This information
+ is now cached only after the frame for that index is decoded and
+ marked as completed, which is done after this check.
+
+ Becuase of this the current check forces extractImage() to return
+ early and abort WebGL texture uploads from image sources.
+
+ This bug was most likely exposed after the refactoring in r206481.
+ https://trac.webkit.org/changeset/206481
+
+ * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
+ (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
+
2016-10-14 Youenn Fablet <you...@apple.com>
MediaResourceLoader should use CachedResource::ressourceError to do CORS checks
Modified: trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp (207331 => 207332)
--- trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp 2016-10-14 09:04:24 UTC (rev 207331)
+++ trunk/Source/WebCore/platform/graphics/cairo/GraphicsContext3DCairo.cpp 2016-10-14 09:17:55 UTC (rev 207332)
@@ -223,7 +223,7 @@
if (m_image->data()) {
decoder.setData(m_image->data(), true);
- if (!decoder.frameCount() || !decoder.frameIsCompleteAtIndex(0))
+ if (!decoder.frameCount())
return false;
m_imageSurface = decoder.createFrameImageAtIndex(0);
} else {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
