Title: [207370] trunk/Tools
- Revision
- 207370
- Author
- [email protected]
- Date
- 2016-10-14 21:18:19 -0700 (Fri, 14 Oct 2016)
Log Message
REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
https://bugs.webkit.org/show_bug.cgi?id=163478
Reviewed by Daniel Bates.
Handle a None other in Contributor.__eq__.
* Scripts/webkitpy/common/config/committers.py:
(Contributor.__eq__):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (207369 => 207370)
--- trunk/Tools/ChangeLog 2016-10-15 02:19:16 UTC (rev 207369)
+++ trunk/Tools/ChangeLog 2016-10-15 04:18:19 UTC (rev 207370)
@@ -1,3 +1,15 @@
+2016-10-14 Simon Fraser <[email protected]>
+
+ REGRESSION (r206973): Running "webkit-patch suggest-reviewers" throws an AttributeError: 'NoneType' object has no attribute 'full_name'
+ https://bugs.webkit.org/show_bug.cgi?id=163478
+
+ Reviewed by Daniel Bates.
+
+ Handle a None other in Contributor.__eq__.
+
+ * Scripts/webkitpy/common/config/committers.py:
+ (Contributor.__eq__):
+
2016-10-14 JF Bastien <[email protected]>
Basic WebAssembly testing
Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (207369 => 207370)
--- trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-15 02:19:16 UTC (rev 207369)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py 2016-10-15 04:18:19 UTC (rev 207370)
@@ -76,7 +76,8 @@
return '"%s" <%s>' % (self.full_name, self.emails[0])
def __eq__(self, other):
- return (self.full_name == other.full_name
+ return (other is not None
+ and self.full_name == other.full_name
and self.emails == other.emails
and self._case_preserved_emails == other._case_preserved_emails
and self.irc_nicknames == other.irc_nicknames
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
