Title: [207439] trunk/Source
Revision
207439
Author
commit-qu...@webkit.org
Date
2016-10-17 15:56:15 -0700 (Mon, 17 Oct 2016)

Log Message

Enable keyboard in fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=163146

Patch by Jeremy Jones <jere...@apple.com> on 2016-10-17
Reviewed by Jer Noble.

Allow keyboard in fullscreen.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _supportsFullScreenForElement:withKeyboard:]):

Source/WebKit2:

* UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::supportsFullScreen):

Modified Paths

Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (207438 => 207439)


--- trunk/Source/WebKit/mac/ChangeLog	2016-10-17 22:30:34 UTC (rev 207438)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-10-17 22:56:15 UTC (rev 207439)
@@ -1,3 +1,15 @@
+2016-10-17  Jeremy Jones  <jere...@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * WebView/WebView.mm:
+        (-[WebView _supportsFullScreenForElement:withKeyboard:]):
+
 2016-10-17  Chris Dumez  <cdu...@apple.com>
 
         Move form.reportValidity() behind InteractiveFormValidation setting

Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (207438 => 207439)


--- trunk/Source/WebKit/mac/WebView/WebView.mm	2016-10-17 22:30:34 UTC (rev 207438)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2016-10-17 22:56:15 UTC (rev 207439)
@@ -8659,7 +8659,7 @@
     if (![[self preferences] fullScreenEnabled])
         return NO;
 
-    return !withKeyboard;
+    return true;
 }
 
 - (void)_enterFullScreenForElement:(WebCore::Element*)element

Modified: trunk/Source/WebKit2/ChangeLog (207438 => 207439)


--- trunk/Source/WebKit2/ChangeLog	2016-10-17 22:30:34 UTC (rev 207438)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-17 22:56:15 UTC (rev 207439)
@@ -1,3 +1,15 @@
+2016-10-17  Jeremy Jones  <jere...@apple.com>
+
+        Enable keyboard in fullscreen.
+        https://bugs.webkit.org/show_bug.cgi?id=163146
+
+        Reviewed by Jer Noble.
+
+        Allow keyboard in fullscreen.
+
+        * UIProcess/WebFullScreenManagerProxy.cpp:
+        (WebKit::WebFullScreenManagerProxy::supportsFullScreen):
+
 2016-10-17  Chris Dumez  <cdu...@apple.com>
 
         Move form.reportValidity() behind InteractiveFormValidation setting

Modified: trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp (207438 => 207439)


--- trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp	2016-10-17 22:30:34 UTC (rev 207438)
+++ trunk/Source/WebKit2/UIProcess/WebFullScreenManagerProxy.cpp	2016-10-17 22:56:15 UTC (rev 207439)
@@ -86,7 +86,7 @@
 
 void WebFullScreenManagerProxy::supportsFullScreen(bool withKeyboard, bool& supports)
 {
-    supports = !withKeyboard;
+    supports = true;
 }
 
 void WebFullScreenManagerProxy::saveScrollPosition()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to